Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SnapshotListenOptions #135

Merged
merged 4 commits into from
Aug 18, 2018
Merged

Add support for SnapshotListenOptions #135

merged 4 commits into from
Aug 18, 2018

Conversation

ted-nz
Copy link

@ted-nz ted-nz commented Aug 16, 2018

Following up on: #134

Adding the ability for the following functions to accept SnapshotListenOptions as an option:

  1. firestore.channel
  2. firestore.syncDocument
  3. firestore.syncCollection

ted-nz added 3 commits August 16, 2018 21:54
The following now accept SnapshotListenOptions as an option: 
1. firestore.channel
2. firestore.syncDocument
3. firestore.syncCollection
Copy link
Owner

@n6g7 n6g7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good!

@n6g7 n6g7 merged commit c32a6b0 into n6g7:master Aug 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants