Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: alternate handler for retrieving Gemini models #315

Merged
merged 2 commits into from
Feb 1, 2025

Conversation

yz778
Copy link
Contributor

@yz778 yz778 commented Jan 29, 2025

If Google API doesn't return models with OpenAI endpoint, try Gemini endpoint (https://ai.google.dev/api/models#method:-models.list)

@n4ze3m
Copy link
Owner

n4ze3m commented Jan 29, 2025

Hey, thank you for the PR! I will test it and reply soon. :)

@n4ze3m n4ze3m self-requested a review January 29, 2025 09:25
@yz778
Copy link
Contributor Author

yz778 commented Jan 30, 2025

Sounds good, let me know if there are any changes you'd like me to make -- or feel free to modify this as you see fit. Thanks!

Copy link
Owner

@n4ze3m n4ze3m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! I didn't know Google has a model listing API. Thank you for the PR. LGTM!

@n4ze3m n4ze3m merged commit 2d1e465 into n4ze3m:main Feb 1, 2025
3 checks passed
@yz778 yz778 deleted the gemini-models branch February 1, 2025 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants