using channel #11
Closed
using channel #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lets try |
|
+1
On Thu 18. Oct 2018 at 21:45, Scott Nichols ***@***.***> wrote:
lets try sink
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#11 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAJnzt_aGLx63Y97q5FhQ_9WOY7tSO3gks5umNpUgaJpZM4XkAPP>
.
--
Sent from Gmail Mobile
|
matzew
force-pushed
the
use_channel_var
branch
from
aacd21e
to
6bc6809
Compare
|
@n3wscott updated |
|
I am going to take the suggestion but not merge it to avoid the CLA issue withe the CLA bot |
|
+1
On Thu 18. Oct 2018 at 23:30, Scott Nichols ***@***.***> wrote:
I am going to take the suggestion but not merge it to avoid the CLA issue
withe the CLA bot
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#11 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAJnziN1AfsAr9jKic83tkDEgYp5HLnUks5umPL6gaJpZM4XkAPP>
.
--
Sent from Gmail Mobile
|
|
@n3wscott/eventing
<reply@reply.github.com>
- updated! :)
…On Thu, Jan 31, 2019 at 3:37 PM Knative Prow Robot ***@***.***> wrote:
New changes are detected. LGTM label has been removed.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<knative#774 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAJnzkbOy9M2fBS_Uj-ujqEjgpFf-2USks5vIw3GgaJpZM4ab2Sz>
.
--
Matthias Wessendorf
github: https://github.com/matzew
twitter: http://twitter.com/mwessendorf
|
n3wscott
pushed a commit
that referenced
this pull request
Mar 5, 2019
Rename Trigger.Spec.Filter.ExactMatch to Trigger.Spec.Filter.SourceAndType. Add unit tests for the filter binary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See for using
channelinstead ofremote:knative#513 (comment)