Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade lru cache #1767

Merged
merged 4 commits into from
May 22, 2023
Merged

upgrade lru cache #1767

merged 4 commits into from
May 22, 2023

Conversation

n1ru4l
Copy link
Owner

@n1ru4l n1ru4l commented May 6, 2023 •
edited
Loading

closes close

@changeset-bot
Copy link

changeset-bot bot commented May 6, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: bea6dd2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@envelop/graphql-jit Major
@envelop/parser-cache Major
@envelop/response-cache Major
@envelop/validation-cache Major
@envelop/response-cache-redis Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2023 •
edited
Loading

💻 Website Preview

The latest changes are available as preview in: https://114e258a.envelop.pages.dev

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2023 •
edited
Loading

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@envelop/core 3.0.7-alpha-20230522135340-bea6dd24 npm ↗︎ unpkg ↗︎
@envelop/apollo-datasources 2.0.7-alpha-20230522135340-bea6dd24 npm ↗︎ unpkg ↗︎
@envelop/apollo-federation 3.0.7-alpha-20230522135340-bea6dd24 npm ↗︎ unpkg ↗︎
@envelop/apollo-server-errors 4.0.7-alpha-20230522135340-bea6dd24 npm ↗︎ unpkg ↗︎
@envelop/apollo-tracing 4.0.7-alpha-20230522135340-bea6dd24 npm ↗︎ unpkg ↗︎
@envelop/auth0 4.0.7-alpha-20230522135340-bea6dd24 npm ↗︎ unpkg ↗︎
@envelop/dataloader 4.0.7-alpha-20230522135340-bea6dd24 npm ↗︎ unpkg ↗︎
@envelop/depth-limit 2.0.7-alpha-20230522135340-bea6dd24 npm ↗︎ unpkg ↗︎
@envelop/disable-introspection 4.0.7-alpha-20230522135340-bea6dd24 npm ↗︎ unpkg ↗︎
@envelop/execute-subscription-event 3.0.7-alpha-20230522135340-bea6dd24 npm ↗︎ unpkg ↗︎
@envelop/extended-validation 2.0.7-alpha-20230522135340-bea6dd24 npm ↗︎ unpkg ↗︎
@envelop/filter-operation-type 4.0.7-alpha-20230522135340-bea6dd24 npm ↗︎ unpkg ↗︎
@envelop/fragment-arguments 4.0.7-alpha-20230522135340-bea6dd24 npm ↗︎ unpkg ↗︎
@envelop/generic-auth 5.0.7-alpha-20230522135340-bea6dd24 npm ↗︎ unpkg ↗︎
@envelop/graphql-jit 6.0.0-alpha-20230522135340-bea6dd24 npm ↗︎ unpkg ↗︎
@envelop/graphql-middleware 4.0.7-alpha-20230522135340-bea6dd24 npm ↗︎ unpkg ↗︎
@envelop/graphql-modules 4.0.7-alpha-20230522135340-bea6dd24 npm ↗︎ unpkg ↗︎
@envelop/immediate-introspection 1.0.7-alpha-20230522135340-bea6dd24 npm ↗︎ unpkg ↗︎
@envelop/live-query 5.0.7-alpha-20230522135340-bea6dd24 npm ↗︎ unpkg ↗︎
@envelop/newrelic 5.0.7-alpha-20230522135340-bea6dd24 npm ↗︎ unpkg ↗︎
@envelop/on-resolve 2.0.7-alpha-20230522135340-bea6dd24 npm ↗︎ unpkg ↗︎
@envelop/opentelemetry 4.1.1-alpha-20230522135340-bea6dd24 npm ↗︎ unpkg ↗︎
@envelop/operation-field-permissions 4.0.7-alpha-20230522135340-bea6dd24 npm ↗︎ unpkg ↗︎
@envelop/parser-cache 6.0.0-alpha-20230522135340-bea6dd24 npm ↗︎ unpkg ↗︎
@envelop/persisted-operations 5.0.7-alpha-20230522135340-bea6dd24 npm ↗︎ unpkg ↗︎
@envelop/preload-assets 4.0.7-alpha-20230522135340-bea6dd24 npm ↗︎ unpkg ↗︎
@envelop/prometheus 7.0.7-alpha-20230522135340-bea6dd24 npm ↗︎ unpkg ↗︎
@envelop/rate-limiter 4.0.7-alpha-20230522135340-bea6dd24 npm ↗︎ unpkg ↗︎
@envelop/resource-limitations 3.0.8-alpha-20230522135340-bea6dd24 npm ↗︎ unpkg ↗︎
@envelop/response-cache 5.0.0-alpha-20230522135340-bea6dd24 npm ↗︎ unpkg ↗︎
@envelop/response-cache-redis 3.0.0-alpha-20230522135340-bea6dd24 npm ↗︎ unpkg ↗︎
@envelop/sentry 5.1.2-alpha-20230522135340-bea6dd24 npm ↗︎ unpkg ↗︎
@envelop/statsd 3.0.7-alpha-20230522135340-bea6dd24 npm ↗︎ unpkg ↗︎
@envelop/validation-cache 6.0.0-alpha-20230522135340-bea6dd24 npm ↗︎ unpkg ↗︎
@envelop/testing 5.0.7-alpha-20230522135340-bea6dd24 npm ↗︎ unpkg ↗︎

@theguild-bot
Copy link
Collaborator

theguild-bot commented May 6, 2023 •
edited
Loading

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.............................................: 100.00% ✓ 579992      ✗ 0     
     data_received......................................: 2.2 GB  15 MB/s
     data_sent..........................................: 126 MB  841 kB/s
     envelop_total......................................: avg=0s      min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:prom-tracing }............................: avg=0s      min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s     
     event_loop_lag.....................................: avg=0s      min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: avg=0s      min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:prom-tracing }............................: avg=0s      min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_blocked...................................: avg=2.54µs  min=800ns   med=1.4µs   max=12.99ms p(90)=2.1µs   p(95)=2.6µs  
     http_req_connecting................................: avg=151ns   min=0s      med=0s      max=2.31ms  p(90)=0s      p(95)=0s     
     http_req_duration..................................: avg=4.81ms  min=193.4µs med=3.48ms  max=80.73ms p(90)=10.32ms p(95)=16ms   
       { expected_response:true }.......................: avg=4.81ms  min=193.4µs med=3.48ms  max=80.73ms p(90)=10.32ms p(95)=16ms   
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: avg=4.01ms  min=414.9µs med=3.5ms   max=57.59ms p(90)=6.46ms  p(95)=7.99ms 
     ✓ { mode:envelop-cache-jit }.......................: avg=2.6ms   min=193.4µs med=1.96ms  max=28.11ms p(90)=4.89ms  p(95)=8.3ms  
     ✓ { mode:envelop-just-cache }......................: avg=4.14ms  min=397.4µs med=3.52ms  max=52.75ms p(90)=7.12ms  p(95)=8.56ms 
     ✓ { mode:graphql-js }..............................: avg=7.5ms   min=690.5µs med=6.3ms   max=53.62ms p(90)=12.19ms p(95)=13.85ms
     ✓ { mode:prom-tracing }............................: avg=18.62ms min=1.85ms  med=16.51ms max=80.73ms p(90)=31.53ms p(95)=33.22ms
     http_req_failed....................................: 0.00%   ✓ 0           ✗ 289996
     http_req_receiving.................................: avg=48.92µs min=12.3µs  med=23.2µs  max=17.1ms  p(90)=35.79µs p(95)=42.8µs 
     http_req_sending...................................: avg=36.53µs min=4.59µs  med=7.9µs   max=24.66ms p(90)=14.8µs  p(95)=21µs   
     http_req_tls_handshaking...........................: avg=0s      min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_waiting...................................: avg=4.73ms  min=163.1µs med=3.43ms  max=80.64ms p(90)=10.03ms p(95)=15.91ms
     http_reqs..........................................: 289996  1933.156888/s
     iteration_duration.................................: avg=5.16ms  min=407.1µs med=3.74ms  max=81.05ms p(90)=10.91ms p(95)=16.36ms
     iterations.........................................: 289996  1933.156888/s
     vus................................................: 10      min=10        max=19  
     vus_max............................................: 20      min=20        max=20

@n1ru4l n1ru4l requested review from kamilkisiela, ardatan and saihaj May 6, 2023 20:46
@n1ru4l @ardatan
upgrade lru cache
436fac2 
add changeset

chore(dependencies): updated changesets for modified dependencies
@ardatan ardatan force-pushed the chore-upgrade-lru-cache branch from fd55fbf to 436fac2 Compare May 22, 2023 13:39
@ardatan ardatan merged commit 0b127cc into main May 22, 2023
@theguild-bot theguild-bot mentioned this pull request May 22, 2023
Merged
@ardatan ardatan deleted the chore-upgrade-lru-cache branch June 22, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saihaj saihaj saihaj approved these changes

@kamilkisiela kamilkisiela Awaiting requested review from kamilkisiela

@ardatan ardatan Awaiting requested review from ardatan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@n1ru4l @theguild-bot @saihaj @ardatan