better function name

certs.sh

@@ -1,4 +1,5 @@
 #!/bin/bash
+set -x
 # call this script with an email address (valid or not).
 # like:
 # ./makecert.sh foo@foo.com

client.go

@@ -86,7 +86,7 @@ func (c *Client) GetSecret(secretService *Service) error {
 		return errs.WithE(err, "Failed to write command")
 	}
 
-	if err := secretService.FromConnection(c.conn); err != nil {
+	if err := secretService.FromReaderUntilNewLine(c.conn); err != nil {
 		return errs.WithE(err, "Failed to get secret")
 	}
 	return nil

cmd/server/main.go

@@ -1,7 +1,6 @@
 package main
 
 import (
-	"github.com/n0rad/go-erlog/errs"
 	"github.com/n0rad/go-erlog/logs"
 	_ "github.com/n0rad/go-erlog/register"
 	"github.com/n0rad/memguarded"
@@ -31,10 +30,6 @@ func execute() error {
 		ServerPem:            "/etc/" + app + "/" + app + ".pem",
 	}
 
-	if err := config.Secret.AskSecret(true, "Secret"); err != nil {
-		return errs.WithE(err, "Failed ask secret")
-	}
-
 	logs.Info("Start")
 	return memguarded.StartServer(config)
 }

server.go

@@ -39,7 +39,7 @@ func (s *Server) Init(secretService *Service) error {
 
 	s.commands["set_secret"] = func(m net.Conn) error {
 		logs.Info("Set secret")
-		if err := secretService.FromConnection(m); err != nil {
+		if err := secretService.FromReaderUntilNewLine(m); err != nil {
 			return err
 		}
 		return nil

service.go

@@ -41,7 +41,7 @@ func (s *Service) FromBytes(secret *[]byte) error {
 	return nil
 }
 
-func (s *Service) FromConnection(conn net.Conn) error {
+func (s *Service) FromReaderUntilNewLine(conn net.Conn) error {
 	buffer, err := memguard.NewBufferFromReaderUntil(conn, '\n')
 	if err != nil && err != io.EOF {
 		return errs.WithE(err, "Failed to read secret from connection")