feat: Accept handler #116
Merged
feat: Accept handler #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't do much, but saves quite a bit of boilerplate at the call site, and also avoids having the task leaking by using AbortOnDropHandle.
matheus23
reviewed
Nov 14, 2024
| @@ -162,7 +164,7 @@ async fn quinn_channel_smoke() -> anyhow::Result<()> { | |||
| /// | |||
| /// This is a regression test. | |||
| #[tokio::test] | |||
| async fn server_away_and_back() -> anyhow::Result<()> { | |||
| async fn server_away_and_back() -> TestResult<()> { | |||
There was a problem hiding this comment.
Eeeeh too late but
Suggested change
| async fn server_away_and_back() -> TestResult<()> { | |
| async fn server_away_and_back() -> TestResult { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a fn to RpcServer to run an accept loop, as well as a fn that spawns an accept loop.
This is to DRY the various places where we now have accept loops, such as
n0-computer/iroh-blobs#11
n0-computer/iroh-docs#7
n0-computer/iroh-gossip#7
This also allows making the tests a bit shorter - you don't have to call abort explicitly anymore on the server JoinHandle.