ci: Pin an older nextest version #3088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We get very weird errors from nextest, I suspect this is a regression. This version is 3 months old, which is probably something nice to try. This does not yet do this everywhere, e.g. windows still installs the latest. But this is enough to see if it helps.
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3088/docs/iroh/ Last updated: 2025-01-03T08:29:32Z |
Arqu
approved these changes
Jan 3, 2025
Every other flaky run in the last month results in FAILEXEC. I looked into the code of nextest and strongly suspect a regression there. If proven right it will be worth to at least report this, ideally figure out their bug (because I suspect this is not easy to reproduce). |
|
Ah ok, I wasn't sure which problem you were referring to. Yeah we need more info there. |
|
😭 And now let's copy this PR into all other repos 🥲 |
This was referenced Jan 3, 2025
|
Wait are we happy with this solution, did it work? |
|
Hard to know for sure. But so far this solution hasn't failed (succeeded 3 times). |
flub
pushed a commit
to n0-computer/iroh-docs
that referenced
this pull request
Jan 10, 2025
## Description <!-- A summary of what this pull request achieves and a rough list of changes. --> Nextest seems to have some issues with file descriptors in the latest version. This pins nextest to a 3 month old version so we get reliable flaky test runs again. ## Breaking Changes <!-- Optional, if there are any breaking changes document them, including how to migrate older code. --> ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> Related PR: n0-computer/iroh#3088 ## Change checklist - [x] Self-review. - ~~[ ] Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant.~~ - ~~[ ] Tests if relevant.~~ - ~~[ ] All breaking changes documented.~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We get very weird errors from nextest, I suspect this is a regression.
This version is 3 months old, which is probably something nice to try.
This does not yet do this everywhere, e.g. windows still installs the
latest. But this is enough to see if it helps.
Breaking Changes
Notes & open questions
Change checklist