chore(deps): Update dependencies #1821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates dependencies of iroh, most notably quinn fixes platform support for android without patches.
This is also used by deltachat currently.
|
ci is very sad, what's the plan there? |
|
to fix it... |
This is a bit much for a maintenance branch, and current nightly does not agree with the proc-macro2 version used in the Cargo.lock file.
We don't need this on a maintenance branch and it's been adjusted for current iroh, not an old version.
Not sure we really care, the linker picks up the wrong library which is probably rather brittle. This failure currently stops the msvc CI task from succeeding which otherwise looks like it might work fine. That one is much more important.
|
@dignifiedquire now CI is happy again. Admittedly I disabled some of it... Do you think it would be reasonable to publish 0.4.2? |
dignifiedquire
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates dependencies of iroh 0.4.1 release, most notably quinn fixes platform support for android without patches.
Notes & open questions
Not all dependencies are updated. Only a few select ones which make things better
for deltachat.
Note that the base of this PR is
maint-0.4which is a branch currently pointingat the 0.4.1 commit.
This PR also bumps the version number already to 0.4.2, we'd have to publish a new
release with this.
This ignores a rust advisory, the way iroh uses the code was determined not to be
problematic and adopting the new API is rather invasive and not suitable for a
maintenance branch. The main branch has updated this code.
Netsim CI is disabled, provides not much value for a maintenance branch and it
has been updated for newer versions of iroh. Keeping it compatible with this
old version is not worth it.
Only stable rust is tested in CI now. The proc-macro2 crate version used in
Cargo.lock does not work with current nightly, which is fine.
This disables the CI check on the Windows/GNU build. There is a linker problem
picking up an MSVC library. Rather than debug this I think we care much more
about MSVC.
Change checklist
Documentation updates if relevant.Tests if relevant.