Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update punycode package to avoid naming collision #112

Closed
wants to merge 1 commit into from
Closed

Update punycode package to avoid naming collision #112

wants to merge 1 commit into from

Conversation

pdehaan
Copy link

@pdehaan pdehaan commented Mar 16, 2018

@mysticatea
Copy link
Owner

Thank you for this PR, and I'm sorry for my delay.

Is this change still better?
The punycode author looks to like require("punycode/"), so I'm worried if punycode.js will be maintained or not.

@mysticatea
Copy link
Owner

I'll close this PR as prefer require("punycode/").
Thank you for contributing!

@mysticatea mysticatea closed this Jul 16, 2018
ota-meshi pushed a commit to ota-meshi/eslint-plugin-node that referenced this pull request Sep 25, 2023
@scagood
feat: add the ability to configure typescript to javascript file exte…
20d2713 
…nsion conversion (mysticatea#112)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
evaluating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pdehaan @mysticatea