Feature/destroy session #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soffokl
reviewed
Dec 7, 2018
zolia
force-pushed
the
feature/destroy-session
branch
from
b56fbb4 to
59313c1
Compare
soffokl
previously approved these changes
Dec 7, 2018
vkuznecovas
suggested changes
Dec 7, 2018
zolia
force-pushed
the
feature/destroy-session
branch
from
59313c1 to
ab6ff2d
Compare
vkuznecovas
reviewed
Dec 7, 2018
zolia
force-pushed
the
feature/destroy-session
branch
from
ab6ff2d to
bd90750
Compare
tadovas
suggested changes
Dec 7, 2018
session/destroy_consumer.go
Outdated
|
|
||
| // destroyConsumer processes session create requests from communication channel. | ||
| type destroyConsumer struct { | ||
| SessionManager Manager |
There was a problem hiding this comment.
You don't need full interface here, only single Destroy method - depend on your own interfaces.
zolia
force-pushed
the
feature/destroy-session
branch
from
626a883 to
f00d582
Compare
zolia
force-pushed
the
feature/destroy-session
branch
from
f00d582 to
487da2b
Compare
zolia
force-pushed
the
feature/destroy-session
branch
from
9a00217 to
1601201
Compare
tadovas
reviewed
Dec 7, 2018
session/manager.go
Outdated
| @@ -51,12 +51,19 @@ type PromiseProcessor interface { | |||
| Stop() error | |||
| } | |||
|
|
|||
| // MemorySessionStorage interface to session storage | |||
| type MemorySessionStorage interface { | |||
There was a problem hiding this comment.
Why it's memory? Simply SessionStorage. Structure satisfying this interface and keeping sessions in memory could be called that
There was a problem hiding this comment.
Since we are in sessions package already. That would give us sessions sessions...
We could call just "Storage" in that case.
There was a problem hiding this comment.
I think just session.Storage is the best choice.
zolia
force-pushed
the
feature/destroy-session
branch
from
1601201 to
b3ede37
Compare
vkuznecovas
previously approved these changes
Dec 10, 2018
soffokl
previously approved these changes
Dec 10, 2018
tadovas
suggested changes
Dec 10, 2018
session/create_consumer.go
Outdated
| // createConsumer processes session create requests from communication channel. | ||
| type createConsumer struct { | ||
| SessionManager Manager | ||
| SessionManager Creator |
There was a problem hiding this comment.
SessionManager var of type Creator sounds weird. Also it's not needed to be public
vkuznecovas
approved these changes
Dec 10, 2018
tadovas
approved these changes
Dec 10, 2018
soffokl
approved these changes
Dec 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Destroys session on failed connect or disconnect.