Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Wireguard service manager #561

Merged
merged 12 commits into from
Nov 29, 2018
Merged

Added Wireguard service manager #561

merged 12 commits into from
Nov 29, 2018

Conversation

soffokl
Copy link
Member

@soffokl soffokl commented Nov 22, 2018 •
edited
Loading

Closes #503

@soffokl soffokl added this to the Keliukis (0.5) milestone Nov 22, 2018
@soffokl soffokl self-assigned this Nov 22, 2018
@soffokl soffokl requested a review from vkuznecovas November 22, 2018 06:10
tadovas
tadovas suggested changes Nov 23, 2018
View reviewed changes
Copy link
Contributor

@tadovas tadovas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really would like to have more clear names and this will be good to go.

zolia
zolia suggested changes Nov 26, 2018
View reviewed changes
Copy link
Contributor

@zolia zolia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more clear naming needed. Some parts can be mocked already.

@soffokl
Copy link
Member Author

soffokl commented Nov 27, 2018

@tadovas @zolia it's ready to review.

@soffokl soffokl requested review from tadovas and zolia November 27, 2018 06:35
tadovas
tadovas suggested changes Nov 27, 2018
View reviewed changes
zolia
zolia suggested changes Nov 27, 2018
View reviewed changes
Copy link
Contributor

@zolia zolia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost... :)

@soffokl soffokl force-pushed the wireguard-service branch 2 times, most recently from 392df8e to ccf3e37 Compare November 28, 2018 05:29
@soffokl
Copy link
Member Author

soffokl commented Nov 28, 2018

@tadovas @zolia @vkuznecovas
If you are not totally tired of it, please take a look at it again. 👀

@soffokl soffokl requested review from vkuznecovas and zolia November 28, 2018 11:54
@soffokl soffokl requested a review from vkuznecovas November 28, 2018 12:07
vkuznecovas
vkuznecovas previously approved these changes Nov 28, 2018
View reviewed changes
@soffokl soffokl requested review from vkuznecovas and zolia November 28, 2018 13:55
zolia
zolia approved these changes Nov 28, 2018
View reviewed changes
Copy link
Contributor

@zolia zolia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, my goal was to get us in line with how we are going to use WG. Will be able to improve on our view in later PRs. Good work :)

tadovas
tadovas approved these changes Nov 29, 2018
View reviewed changes
Copy link
Contributor

@tadovas tadovas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really hope this works. Lets move this to master, but keeping in mind there is alot to improve.

@tadovas tadovas merged commit 5a73287 into master Nov 29, 2018
@soffokl soffokl deleted the wireguard-service branch November 29, 2018 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadovas tadovas tadovas approved these changes

@zolia zolia zolia approved these changes

@vkuznecovas vkuznecovas vkuznecovas approved these changes

Assignees

@soffokl soffokl

Labels
enhancement
Projects
None yet
Milestone
Keliukis (0.5)
Development

Successfully merging this pull request may close these issues.
4 participants
@soffokl @tadovas @zolia @vkuznecovas