Generate tequilapi json as build artifact #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
interro
commented
Nov 13, 2018
•
interro
commented
- tequilapi.json will be added to dev release
zolia
previously approved these changes
Nov 13, 2018
interro
force-pushed
the
tequilapi-build-artifact
branch
from
d95c7b3 to
e16b421
Compare
interro
force-pushed
the
tequilapi-build-artifact
branch
from
e16b421 to
fc62f59
Compare
zolia
previously approved these changes
Nov 13, 2018
soffokl
reviewed
Nov 13, 2018
.travis.yml
Outdated
| - script: | ||
| - go get github.com/go-swagger/go-swagger/cmd/swagger/ | ||
| - bin/swagger_generate | ||
| - bin/s3 sync tequilapi.json s3://travis-$TRAVIS_BUILD_NUMBER/build-artifacts |
There was a problem hiding this comment.
Suggested change
| - bin/s3 sync tequilapi.json s3://travis-$TRAVIS_BUILD_NUMBER/build-artifacts | |
| - bin/s3 cp tequilapi.json s3://travis-$TRAVIS_BUILD_NUMBER/build-artifacts/ |
There was a problem hiding this comment.
sync should be applied for directories only, cp for files.
soffokl
reviewed
Nov 13, 2018
.travis.yml
Outdated
| - script: | ||
| - go get github.com/go-swagger/go-swagger/cmd/swagger/ | ||
| - bin/swagger_generate | ||
| - bin/s3 cp tequilapi.json s3://travis-$TRAVIS_BUILD_NUMBER/build-artifacts |
There was a problem hiding this comment.
Suggested change
| - bin/s3 cp tequilapi.json s3://travis-$TRAVIS_BUILD_NUMBER/build-artifacts | |
| - bin/s3 cp tequilapi.json s3://travis-$TRAVIS_BUILD_NUMBER/build-artifacts/ |
and / at the end, or it will create file /build-artifacts instead of directory.
…MysteriumNetwork/node into tequilapi-build-artifact
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.