Added publishing Android SDK to Bintray and JCenter. #520 #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soffokl
commented
Nov 8, 2018
| <modelVersion>4.0.0</modelVersion> | ||
| <groupId>network.mysterium.Node</groupId> | ||
| <artifactId>Mysterium</artifactId> | ||
| <version>0.0.0</version> |
There was a problem hiding this comment.
This version will be replaced using git tag for every release.
There was a problem hiding this comment.
groupId: should reflect grouping. And it must be lowercase. Essentially it's like java package - a namespace.
ArtifactId: I would vote for MobileNode.aar - because that's its purpose, and for group id: simply misterium.network, maybe we will produce more artifacts not related to node itself
There was a problem hiding this comment.
Changed groupId and artifactId.
There was a problem hiding this comment.
And sorry for my mistake - it should be mobile-node. No upper cases - words separated by hyphen.
soffokl
force-pushed
the
android-publish
branch
2 times, most recently
from
cb74d13 to
4055b6e
Compare
soffokl
force-pushed
the
android-publish
branch
from
4055b6e to
a5ab473
Compare
tadovas
approved these changes
Nov 8, 2018
vkuznecovas
approved these changes
Nov 8, 2018
soffokl
added a commit
that referenced
this pull request
Nov 9, 2018
Added publishing Android SDK to Bintray and JCenter. #520
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.