Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont need state for connection.ConnectionCreator #497

Merged
merged 2 commits into from
Oct 25, 2018
Merged

Dont need state for connection.ConnectionCreator #497

merged 2 commits into from
Oct 25, 2018

Conversation

Waldz
Copy link
Member

@Waldz Waldz commented Oct 24, 2018 •
edited
Loading

updates #476

@Waldz Waldz mentioned this pull request Oct 24, 2018
Closed
10 tasks
soffokl
soffokl approved these changes Oct 25, 2018
View reviewed changes
Copy link
Member

@soffokl soffokl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

tadovas
tadovas approved these changes Oct 25, 2018
View reviewed changes
Copy link
Contributor

@tadovas tadovas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks simpler

@Waldz Waldz merged commit 2acda60 into master Oct 25, 2018
@Waldz Waldz deleted the enhancement/stateless-connection-factory branch October 27, 2018 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadovas tadovas tadovas approved these changes

@soffokl soffokl soffokl approved these changes

@zolia zolia zolia approved these changes

@vkuznecovas vkuznecovas vkuznecovas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Waldz @tadovas @soffokl @zolia @vkuznecovas