Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quiting the cli hangs instead of quitting #462

Closed
tcharding opened this issue Oct 18, 2018 · 1 comment
Closed

Quiting the cli hangs instead of quitting #462

tcharding opened this issue Oct 18, 2018 · 1 comment
Assignees
@soffokl

Comments

@tcharding
Copy link
Contributor

Running bin/run cli then entering command quit (or exit) outputs a goodbye message then prints the cli prompt again, the cli hangs at this stage (Ctl-C does not work).
@tcharding tcharding mentioned this issue Oct 18, 2018
Closed
@soffokl
Copy link
Member

soffokl commented Oct 22, 2018

I have commented in the PR:

Looks like this is a bug in the package that we are using chzyer/readline#136
It fixed in master, but we are using the latest version and we don't have the fix released.
We can workaround it somehow, or just use the master branch in dep

There is an issue, that request a new release:

@soffokl soffokl mentioned this issue Oct 23, 2018
Merged
@soffokl soffokl self-assigned this Oct 23, 2018
soffokl added a commit that referenced this issue Oct 23, 2018
@soffokl
Updated chzyer/readline to fix CLI quit commant. #462
31d2aca
soffokl added a commit that referenced this issue Oct 23, 2018
@soffokl
Updated chzyer/readline to fix CLI quit command. #462
822d9af
@soffokl soffokl mentioned this issue Oct 23, 2018
Merged
soffokl added a commit that referenced this issue Oct 23, 2018
@soffokl
Updated chzyer/readline to fix CLI quit command. #462 (#477)
9fa5c3b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@soffokl soffokl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Quit cli when receiving command quit
2 participants
@soffokl @tcharding