Skip to content

Commit

Permalink
PR remarks fixed
Browse files Browse the repository at this point in the history
  • Loading branch information
tadovas committed Dec 10, 2018
1 parent 9991ac6 commit 94dead9
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions service_discovery/dto/contact.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ type Contact struct {
Definition ContactDefinition `json:"definition"`
}

// ContactDefinition is marker interface for contacts of all types
// ContactDefinition is interface for contacts of all types
type ContactDefinition interface {
}

Expand Down Expand Up @@ -88,8 +88,8 @@ func unserializeContact(contactType string, rawMessage *json.RawMessage) Contact
if !ok {
return UnsupportedContactType{}
}
definition, er := fn(rawMessage)
if er != nil {
definition, err := fn(rawMessage)
if err != nil {
return UnsupportedContactType{}
}

Expand Down
2 changes: 1 addition & 1 deletion service_discovery/dto/payment_method.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import (
"github.com/mysteriumnetwork/node/money"
)

// PaymentMethod is a marker interface for all types of payment methods
// PaymentMethod is a interface for all types of payment methods
type PaymentMethod interface {
// Service price per unit of metering
GetPrice() money.Money
Expand Down
2 changes: 1 addition & 1 deletion service_discovery/dto/service_definition.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ package dto

import "encoding/json"

// ServiceDefinition interface is marker interface for all service definition types
// ServiceDefinition interface is interface for all service definition types
type ServiceDefinition interface {
GetLocation() Location
}
Expand Down
2 changes: 1 addition & 1 deletion service_discovery/dto/service_proposal.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const (
proposalFormat = "service-proposal/v1"
)

// ServiceProposal is top level structure which is presented to marked place by service provider, and looked up by service consumer
// ServiceProposal is top level structure which is presented to marketplace by service provider, and looked up by service consumer
// service proposal can be marked as unsupported by deserializer, because of unknown service, payment method, or contact type
type ServiceProposal struct {
// Per provider unique serial number of service description provided
Expand Down

0 comments on commit 94dead9

Please sign in to comment.