Create versions of broken check funcs compatible with gomodules #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Introducing `D` version of each broken check to operate on directory
instead of packages. This allows operating on dirs outside GOPATH.
* Leaving old versions for compatibility until all of our go
projects are migrated to go.mod.
* Change in usage:
`commands.Check("./...", "docs")` → `commands.CheckD(".", "docs")`
* Common excludes are defined in `util.GoLintExcludes()`
tadaskay
force-pushed
the
gomod-support
branch
from
479b0ab to
7ff1be9
Compare
vkuznecovas
approved these changes
Sep 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using go 1.13 in https://github.com/mysteriumnetwork/feedback with go.mod, thus I need the checks working
Introducing
Dversion of each broken check to operate on directoryinstead of packages. This allows operating on dirs outside GOPATH.
Leaving old versions for compatibility until all of our go
projects are migrated to go.mod.
Change in usage:
commands.Check("./...", "docs")→commands.CheckD(".", "docs")util.GoLintExcludes()and are used by all the check funcs