moved the ci tools from go-openvpn to goci #1
Conversation
vkuznecovas
force-pushed
the
migrate-tools
branch
from
7c2c296 to
c8f3875
Compare
vkuznecovas
force-pushed
the
migrate-tools
branch
from
c8f3875 to
39b0e5c
Compare
.gitignore
Outdated
| @@ -0,0 +1,14 @@ | |||
| # Binaries for programs and plugins | |||
| *.exe | |||
There was a problem hiding this comment.
Why to push files, which is not actual for this repo
README.md
Outdated
|
|
||
| // ExludedDirs contains the list of directories that we'll exclude for the repo | ||
| var ExludedDirs = []string{".git", "vendor", "build", "docs"} |
There was a problem hiding this comment.
go list ./.. solves problem better ;)
Scans only for Go packages and skips additional configuration of some dirs
README.md
Outdated
|
|
||
| // Checks for copyright headers in files | ||
| func Copyright() error { |
README.md
Outdated
|
|
||
| // Checks for issues with go imports | ||
| func GoImports() error { |
There was a problem hiding this comment.
Actualy would be design have syntax mage check [standard]:
mage check- performs all quality checks (CheckCopyright,CheckGolint,CheckGoomports)mage check copyright- checks only specific quality standard
commands/command_goreport.go
Outdated
| } | ||
|
|
||
| // GoReport updates the go report for the given repo | ||
| func GoReport(pkg string) error { |
commands/command_govet.go
Outdated
| if path == "" { | ||
| path = "../..." | ||
| } | ||
| out, err := sh.Output("go", "vet", "-composites=false", path) |
There was a problem hiding this comment.
-composites=false should be injected by project, and currently is needed only in node project
…ossibility to run all the common checks via single command.
vkuznecovas
force-pushed
the
migrate-tools
branch
from
433ba63 to
e80badc
Compare
commands/command_govet.go
Outdated
| ) | ||
|
|
||
| // GoVet checks that the source is compliant with go vet | ||
| func GoVet(path string, aditionalArgs ...string) error { |
commands/command_golint.go
Outdated
| } | ||
|
|
||
| func formatAndPrintGoLintOutput(rawGolint string) { | ||
| packageErrorMap := make(map[string][]string, 0) |
There was a problem hiding this comment.
it can be packageErrorMap := make(map[string][]string)
README.md
Outdated
|
|
||
|
|
||
| ``` |
There was a problem hiding this comment.
I suggest adding syntax highlighting ```golang
README.md
Outdated
| To use it, include a makefile in root of your repo directory | ||
|
|
||
| ``` |
There was a problem hiding this comment.
I suggest adding syntax highlighting ```makefile
README.md
Outdated
|
|
||
|
|
||
| Then, create a ci folder to contain all the mage files you need. To include the common scripts from this library, a following file is suggested: |
There was a problem hiding this comment.
ci -> CI or mark it with quotes somehow or ci/
No description provided.