Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It would be good to add some idleTimeout to pool options #962

Open
dusmanija opened this issue Dec 18, 2014 · 9 comments · May be fixed by #2218
Open

It would be good to add some idleTimeout to pool options #962

dusmanija opened this issue Dec 18, 2014 · 9 comments · May be fixed by #2218

Comments

@dusmanija
Copy link

Hello,

I am using this module for a long time but it lacks one failsafe element. My code for database functions became very big and it is hard to find where connection is not closed or if some errors happened before connection is closed that connection will stay idle and eventually when all are consumed from the pool the application hangs on database calls. It would be good to add some option like idelConnectionTimeout that will destroy a connection from a pool if it is idle for set time. This way pool will never stuck and will create fresh connections to replace those that hanged. Also if some mechanism could be made to auto close connection on end that would be great but i think that is not an option...

@dougwilson
Copy link
Member

The most flexible way would be we can add an options object to the getConnection where you can say "hey, if the connection sits idle for x seconds, this is an error and kill the connection".

@brendanashworth
Copy link

I'd like to see this feature implemented, it is quite a pain (especially with error handling) to locate a connection leak. Sometimes I resolve to refreshing each page 11 times (10 = max connections) until it dies.

@seme1
Copy link

seme1 commented Feb 3, 2015

Same here. Please implement this feature.

@lroal
Copy link

lroal commented Feb 22, 2015

This would be a nice feature.

@dougwilson
Copy link
Member

PRs are welcome :)!

@brendanashworth
Copy link

Doesn't #802 do this?

@dougwilson
Copy link
Member

No

@AdriVanHoudt
Copy link

+1 for this, now to find time for a PR 😃

@akuma
Copy link

akuma commented Dec 5, 2016

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

7 participants