-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It would be good to add some idleTimeout to pool options #962
Comments
The most flexible way would be we can add an options object to the |
I'd like to see this feature implemented, it is quite a pain (especially with error handling) to locate a connection leak. Sometimes I resolve to refreshing each page 11 times (10 = max connections) until it dies. |
Same here. Please implement this feature. |
This would be a nice feature. |
PRs are welcome :)! |
Doesn't #802 do this? |
No |
+1 for this, now to find time for a PR 😃 |
+1 |
Hello,
I am using this module for a long time but it lacks one failsafe element. My code for database functions became very big and it is hard to find where connection is not closed or if some errors happened before connection is closed that connection will stay idle and eventually when all are consumed from the pool the application hangs on database calls. It would be good to add some option like idelConnectionTimeout that will destroy a connection from a pool if it is idle for set time. This way pool will never stuck and will create fresh connections to replace those that hanged. Also if some mechanism could be made to auto close connection on end that would be great but i think that is not an option...
The text was updated successfully, but these errors were encountered: