Use standard area_from_code for legacy code lookup #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #420 +/- ##
==========================================
+ Coverage 75.00% 75.27% +0.26%
==========================================
Files 47 47
Lines 2805 2811 +6
==========================================
+ Hits 2104 2116 +12
+ Misses 701 695 -6 ☔ View full report in Codecov by Sentry. |
davea
approved these changes
Jan 2, 2024
This should mean no unhandled server errors if multiple results returned, and both endpoints should act the same.
dracos
force-pushed
the
multiple-gss-code-fix-2
branch
from
e0bb011 to
43abf6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should mean no unhandled server errors if multiple results returned, and both endpoints should act the same (so the /code lookup will now pass through a query string, and the legacy /area lookup should cope better with multiple results, and you could now include a type to differentiate between WMC/WMCF).