Add XLS analyze job #8073
Closed
Add XLS analyze job #8073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving into its own module so we can reuse this code for scanning `xls` files and maybe even raw emails too.
Rename as ExcelAnalyzer::XlsxAnalyzer to distinguish from a new xls analyzer we're creating.
Not enabled by default we will start by running this analyzer manually in the Rails console and Sidekiq before to test performance and how good it is at detecting issues before allowing it to run freely in production.
Delegate expire and log_event to the `info_request` to simplify attachment admin updates.
Allow us to reuse the event logging when attachments are hidden or updated automatically in the future.
Allow testing of the new XLS analyzer from the Rails console and Sidekiq on historical attachments so we can do more testing before allowing this to run in production.
|
Not intending to merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Extracted from #8060
Depends on #8060
Depends on #8072
What does this do?
Adds background job to analyze old XLS attachments and hide them if hidden data is detected.
Why was this needed?
Used to hide old potentially problematic attachments on WDTK.
Implementation notes
Not sure we need this in develop but saving for posterity.
[skip changelog]