Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an extra conditional inside maybeNewConcept #85

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

travis
Copy link
Contributor

@travis travis commented Jan 10, 2022

this was blowing up on page load, presumably because the workspace wasn't loaded yet

this was blowing up on page load, presumably because the workspace wasn't loaded yet
@vercel
Copy link

vercel bot commented Jan 10, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mysilio/garden/DZgYksw5Mm5huNmYyUHLBrcT97Jf
✅ Preview: https://garden-git-direct-navigation-bug.mysilio.page

Copy link
Contributor

@ianconsolata ianconsolata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand why this fixes it, but as long as it does looks great!

@travis
Copy link
Contributor Author

travis commented Jan 11, 2022

oh so I think the actual problem here was that the note storage URI was being calculated as null since the workspace wasn't loaded yet, and then we tried to set that null URI as the object of US.storedAt which was what was actually throwing the error. after this update we just return null from maybeNewConcept which results in the calling hook going down a different path and returning a value that tells the UI that things haven't loaded yet

@travis travis merged commit f9d4a2b into main Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants