Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search #63

Merged
merged 8 commits into from
Nov 5, 2021
Merged

Search #63

merged 8 commits into from
Nov 5, 2021

Conversation

ianconsolata
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Nov 2, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mysilio/garden/9xogUsEArAHMqjez6GYoZkQRKRox
✅ Preview: https://garden-git-search.mysilio.page

@ianconsolata
Copy link
Contributor Author

Closing #60, just included those changes in this PR

@ianconsolata ianconsolata changed the base branch from main to staging November 2, 2021 05:41
Copy link
Contributor

@travis travis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly aesthetic fixes, but would be great to have them addressed - lgtm!

import Cards from '../components/Cards';
import { FurnitureStore } from 'rdf-namespaces/dist/schema'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like you aren't using this? also lol what is a FurnitureStore!?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think VSCode autocomplete must have added these imports. I don't think I use anything from rdf-namespaces.

const avatarImgSrc = profile && getUrl(profile, FOAF.img);
const [activeModal, setActiveModal] = useState(undefined);
const bg = (type == 'dashboard') ? 'bg-header-gradient' : 'bg-my-green';
const bg = type == 'dashboard' ? 'bg-header-gradient' : 'bg-my-green';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we keep the parens here? I know they are for show, but this breaks my brain just a little without them when I try to read it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeah. I think this was Prettier, I prefer parens too.

@@ -6,6 +6,7 @@ import { DCTERMS, FOAF } from "@inrupt/vocab-common-rdf";
import { conceptIdFromUri } from "../../model/concept";
import { notePath, urlSafeIdToConceptName } from "../../utils/uris";
import { getRelativeTime } from '../../utils/time.js';
import { workspace } from "rdf-namespaces/dist/space";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not being used, I think

const { fuse } = useFuse(garden);
if (search) {
const result = fuse.search(search);
console.log(garden, search, result);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete console.log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants