-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search #63
Search #63
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/mysilio/garden/9xogUsEArAHMqjez6GYoZkQRKRox |
Closing #60, just included those changes in this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly aesthetic fixes, but would be great to have them addressed - lgtm!
components/Dashboard.jsx
Outdated
import Cards from '../components/Cards'; | ||
import { FurnitureStore } from 'rdf-namespaces/dist/schema' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like you aren't using this? also lol what is a FurnitureStore!?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think VSCode autocomplete must have added these imports. I don't think I use anything from rdf-namespaces.
components/Header.jsx
Outdated
const avatarImgSrc = profile && getUrl(profile, FOAF.img); | ||
const [activeModal, setActiveModal] = useState(undefined); | ||
const bg = (type == 'dashboard') ? 'bg-header-gradient' : 'bg-my-green'; | ||
const bg = type == 'dashboard' ? 'bg-header-gradient' : 'bg-my-green'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we keep the parens here? I know they are for show, but this breaks my brain just a little without them when I try to read it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh yeah. I think this was Prettier, I prefer parens too.
components/cards/NoteCard.jsx
Outdated
@@ -6,6 +6,7 @@ import { DCTERMS, FOAF } from "@inrupt/vocab-common-rdf"; | |||
import { conceptIdFromUri } from "../../model/concept"; | |||
import { notePath, urlSafeIdToConceptName } from "../../utils/uris"; | |||
import { getRelativeTime } from '../../utils/time.js'; | |||
import { workspace } from "rdf-namespaces/dist/space"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not being used, I think
hooks/concepts.jsx
Outdated
const { fuse } = useFuse(garden); | ||
if (search) { | ||
const result = fuse.search(search); | ||
console.log(garden, search, result); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete console.log
No description provided.