upgrade to the latest version of swrlit #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/mysilio/garden/5Fj2v4MhdrL1nSBF9qrKGHGPtgtw |
some big changes here: 1) swrlit 1.0.0 uses the latest solid auth library, which means authenticated users see a quick page redirect when they load a page in which the browser is reauthenticating with the IDP. we really don't want to render before the redirect does its thing, so move the AuthenticationProvider above everything else in the app and don't render anything inside it until it has an `info` object - this will happen only after the redirect. 2) move handleToIdp into garden since it is no longer in swrlit
Based on the failed build messages, and the fact that the inrupt vocab library got bumped to 1.0+
ianconsolata
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some big changes here:
swrlit 1.0.0 uses the latest solid auth library, which means authenticated users see a quick page redirect when they load a page in which the browser is reauthenticating with the IDP. we really don't want to render before the redirect does its thing, so move the AuthenticationProvider above everything else in the app and don't render anything inside it until it has an
infoobject - this will happen only after the redirect.move handleToIdp into garden since it is no longer in swrlit