Staging #36
Merged
Staging #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow the pattern we were using from plate of having a button in the toolbar that inserts an image. Customize that button because it was not stopping event propagation which would auto-close the modal dialog. Factor out a "Modal" component. Also get rid of legacy button classes.
Image uploads in the editor
this is the Plate version of the same function so should be a bit better
This thing is a bit of a beast. In order to make a note private at the moment we move it into a different directory inside either the public or private directories in the user's POD. We do this because we don't want to muck around with ACLs quite yet, but this design decision should be revisited soon. For the moment, this means that we need to do several operations when we change privacy: 1) create the new note resource 2) update both the public and private index and finally 3) delete the old note resource This is why we have so many hooks below, and two separate functions for making a note public or private.
use useStoreEditorRef instead of useSlateStatic
Get the privacy toggle working again
Don't show editing controls on other peoples' notes
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/mysilio/garden/GgzWYXRx4nsAbXAiXRFDeAk6Epaj |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.