Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: plural_forms, not plural-forms #89

Merged
merged 1 commit into from
Apr 26, 2024
Merged

fix: plural_forms, not plural-forms #89

merged 1 commit into from
Apr 26, 2024

Conversation

sjinks
Copy link
Contributor

@sjinks sjinks commented Apr 26, 2024

According to the description, the correct key name is plural_forms, not plural-forms.

Another implementation of po2json also uses plural_forms.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sjinks
Copy link
Contributor Author

sjinks commented Apr 26, 2024

Jed also uses plural_forms.

@myrotvorets-team myrotvorets-team merged commit ac05638 into myrotvorets:master Apr 26, 2024
1 check passed
@sjinks sjinks deleted the patch-1 branch April 26, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myrotvorets-team myrotvorets-team myrotvorets-team approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjinks @myrotvorets-team