Use script in the mypy repository to build wheels #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes inline configuration and moves it to a script. This makes it easier to have more complex logic during the build, and also we can more easily test the build locally. Also there's less need to understand the details of how GitHub actions are configured. Related to python/mypy#10074.
ilevkivskyi
approved these changes
Feb 16, 2021
|
Closing an reopening to restart the builds now that I've merged python/mypy#10096 that this depends on. |
|
Hmm the CI build will fail until there's been a successful build triggered from the mypy repo. I'm merging this now but will validate whether things work afterwards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes inline configuration and moves it to a script.
This makes it easier to have more complex logic during the build,
and also we can more easily test the build locally.
Also there's less need to understand the details of how GitHub actions
are configured.
Related to python/mypy#10074.