fix(settings): improve saving settings

myparcelnl · Nov 6, 2023 · b313793 · b313793
1 parent 1a86415
commit b313793
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/Configuration/Service/Ps17PsConfigurationService.php b/src/Configuration/Service/Ps17PsConfigurationService.php
@@ -74,6 +74,8 @@ public function has(string $key, ShopConstraint $shopConstraint = null): bool
      */
     public function set(string $key, $value, ShopConstraint $shopConstraint = null): void
     {
-        $this->configurationService->set($key, json_encode($value), $shopConstraint);
+        $storableValue = is_scalar($value) ? $value : json_encode($value);
+
+        $this->configurationService->set($key, $storableValue, $shopConstraint);
     }
 }
diff --git a/src/Pdk/Settings/Repository/PdkSettingsRepository.php b/src/Pdk/Settings/Repository/PdkSettingsRepository.php
@@ -52,5 +52,6 @@ public function store(string $key, $value): void
         }
 
         $this->configurationService->set($key, $value);
+        $this->save($key, $value);
     }
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -52,5 +52,6 @@ public function store(string $key, $value): void @@
             }
             $this->configurationService->set($key, $value);
+            $this->save($key, $value);
         }
     }