Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: select delivery date for small package type #263

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Conversation

MPClerise
Copy link
Contributor

INT-752

@MPClerise MPClerise self-assigned this Dec 10, 2024
@MPClerise MPClerise requested a review from a team as a code owner December 10, 2024 06:10
Copy link

netlify bot commented Dec 10, 2024

Deploy Preview for myparcel-delivery-options ready!

Name Link
🔨 Latest commit 1c65dec
🔍 Latest deploy log https://app.netlify.com/sites/myparcel-delivery-options/deploys/675aba9561ec8a000805ecca
😎 Deploy Preview https://deploy-preview-263--myparcel-delivery-options.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 10, 2024

Bundle Report

Changes will increase total bundle size by 92 bytes (0.03%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@myparcel/delivery-options-MyParcelDeliveryOptionsLib-esm 183.01kB 46 bytes (0.03%) ⬆️
@myparcel/delivery-options-MyParcelDeliveryOptionsLib-esm-MyParcelDeliveryOptionsLib-umd 138.15kB 46 bytes (0.03%) ⬆️

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.19%. Comparing base (472c4c5) to head (1c65dec).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...ps/delivery-options/src/composables/useFeatures.ts 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #263      +/-   ##
==========================================
+ Coverage   75.17%   75.19%   +0.02%     
==========================================
  Files         342      342              
  Lines        7397     7399       +2     
  Branches      643      642       -1     
==========================================
+ Hits         5561     5564       +3     
  Misses       1203     1203              
+ Partials      633      632       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

apps/delivery-options/src/composables/useFeatures.ts Outdated Show resolved Hide resolved
apps/delivery-options/src/composables/useFeatures.ts Outdated Show resolved Hide resolved
libs/shared/src/data/enums.ts Outdated Show resolved Hide resolved
@FreekVR
Copy link
Contributor

FreekVR commented Dec 11, 2024

note: commits must be squashed or rebased together before merging!

Clerise Swart added 2 commits December 12, 2024 13:59
@myparcel-bot myparcel-bot bot added approved (Auto) and removed changes requested (Auto) labels Dec 12, 2024
@MPClerise MPClerise added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit fbd1c43 Dec 12, 2024
12 checks passed
@MPClerise MPClerise deleted the fix/INT-752 branch December 12, 2024 10:34
myparcel-bot bot added a commit that referenced this pull request Dec 12, 2024
## [@myparcel/delivery-options-v6.5.1](v6.5.0...v6.5.1) (2024-12-12)

### 🐛 Bug Fixes

* select delivery date for small package type ([#263](#263)) ([fbd1c43](fbd1c43))
@myparcel-bot
Copy link
Contributor

myparcel-bot bot commented Dec 12, 2024

🎉 This issue has been resolved in version @myparcel/delivery-options-v6.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants