Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow UPS standard delivery in NL & BE, add UPS express delivery #262

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

FreekVR
Copy link
Contributor

@FreekVR FreekVR commented Nov 27, 2024

fixes INT-659

@FreekVR FreekVR requested a review from a team as a code owner November 27, 2024 10:58
@FreekVR FreekVR marked this pull request as draft November 27, 2024 10:58
Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for myparcel-delivery-options ready!

Name Link
🔨 Latest commit cd15937
🔍 Latest deploy log https://app.netlify.com/sites/myparcel-delivery-options/deploys/6750375ace6d920008def105
😎 Deploy Preview https://deploy-preview-262--myparcel-delivery-options.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 27, 2024

Bundle Report

Changes will increase total bundle size by 969 bytes (0.3%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@myparcel/delivery-options-MyParcelDeliveryOptionsLib-esm 182.96kB 537 bytes (0.29%) ⬆️
@myparcel/delivery-options-MyParcelDeliveryOptionsLib-esm-MyParcelDeliveryOptionsLib-umd 138.11kB 432 bytes (0.31%) ⬆️

@FreekVR FreekVR force-pushed the feat/int-659-extra-ups-options branch from dc1bc07 to e9ade82 Compare November 27, 2024 11:47
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 62.00000% with 19 lines in your changes missing coverage. Please review.

Project coverage is 75.17%. Comparing base (70ec73b) to head (cd15937).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...ions/src/composables/useResolvedDeliveryOptions.ts 50.00% 0 Missing and 12 partials ⚠️
apps/sandbox/src/form/availableInPlatform.ts 0.00% 3 Missing ⚠️
...box/src/config/getDefaultSandboxCarrierSettings.ts 0.00% 2 Missing ⚠️
...very-options/src/config/handleDeprecatedOptions.ts 66.66% 0 Missing and 1 partial ⚠️
libs/shared/src/utils/getAllConfigOptions.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #262      +/-   ##
==========================================
- Coverage   75.27%   75.17%   -0.10%     
==========================================
  Files         342      342              
  Lines        7369     7397      +28     
  Branches      635      643       +8     
==========================================
+ Hits         5547     5561      +14     
- Misses       1197     1203       +6     
- Partials      625      633       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FreekVR FreekVR force-pushed the feat/int-659-extra-ups-options branch 2 times, most recently from 1e857ca to eef7147 Compare November 29, 2024 11:34
@FreekVR FreekVR force-pushed the feat/int-659-extra-ups-options branch 2 times, most recently from 990f389 to 1890e27 Compare December 4, 2024 10:52
@FreekVR FreekVR requested a review from joerivanveen December 4, 2024 10:52
@FreekVR FreekVR force-pushed the feat/int-659-extra-ups-options branch 2 times, most recently from 435b33b to 1acf14a Compare December 4, 2024 11:04
@FreekVR FreekVR force-pushed the feat/int-659-extra-ups-options branch from 1acf14a to cd15937 Compare December 4, 2024 11:04
@FreekVR FreekVR marked this pull request as ready for review December 4, 2024 11:05
@FreekVR FreekVR requested a review from a team as a code owner December 4, 2024 11:05
@FreekVR FreekVR changed the title feat: allow UPS standard delivery in NL & BE feat: allow UPS standard delivery in NL & BE, add UPS express delivery Dec 4, 2024
@myparcel-bot myparcel-bot bot added the approved (Auto) label Dec 6, 2024
@GravendeelJochem GravendeelJochem added this pull request to the merge queue Dec 10, 2024
Merged via the queue into main with commit 472c4c5 Dec 10, 2024
15 of 16 checks passed
@GravendeelJochem GravendeelJochem deleted the feat/int-659-extra-ups-options branch December 10, 2024 08:49
myparcel-bot bot added a commit that referenced this pull request Dec 10, 2024
## [@myparcel/delivery-options-v6.5.0](v6.4.2...v6.5.0) (2024-12-10)

### ✨ New Features

* allow UPS standard delivery in NL & BE, add UPS express delivery ([#262](#262)) ([472c4c5](472c4c5))
@myparcel-bot
Copy link
Contributor

myparcel-bot bot commented Dec 10, 2024

🎉 This issue has been resolved in version @myparcel/delivery-options-v6.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants