Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: align pickup times with API data #256

Merged
merged 1 commit into from
Dec 3, 2024
Merged

fix: align pickup times with API data #256

merged 1 commit into from
Dec 3, 2024

Conversation

MPClerise
Copy link
Contributor

@MPClerise MPClerise commented Oct 30, 2024 •
edited
Loading

Fixed weekday ordering and mapped pickup times accurately to match API data.

INT-663

@MPClerise MPClerise requested a review from a team as a code owner October 30, 2024 14:46
@netlify Netlify
Copy link

netlify bot commented Oct 30, 2024 •
edited
Loading

✅ Deploy Preview for myparcel-delivery-options ready!

Name Link
🔨 Latest commit 2f100f3
🔍 Latest deploy log https://app.netlify.com/sites/myparcel-delivery-options/deploys/674ee0e61df07a00086e55f5
😎 Deploy Preview https://deploy-preview-256--myparcel-delivery-options.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov Codecov
Copy link

codecov bot commented Oct 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.27%. Comparing base (61f9281) to head (2f100f3).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #256      +/-   ##
==========================================
- Coverage   75.29%   75.27%   -0.03%     
==========================================
  Files         342      342              
  Lines        7376     7369       -7     
  Branches      635      635              
==========================================
- Hits         5554     5547       -7     
  Misses       1197     1197              
  Partials      625      625

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov Codecov
Copy link

codecov bot commented Oct 30, 2024 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 48.79kB (17.98%) ⬆️⚠️, exceeding the configured threshold of 5%.

Bundle name Size Change
@myparcel/delivery-options-MyParcelDeliveryOptionsLib-esm 182.43kB 29.33kB (19.16%) ⬆️⚠️
@myparcel/delivery-options-MyParcelDeliveryOptionsLib-esm-MyParcelDeliveryOptionsLib-umd 137.67kB 19.46kB (16.46%) ⬆️⚠️

@myparcel-bot myparcel-bot bot added the changes requested (Auto) label Oct 30, 2024
joerivanveen
joerivanveen requested changes Oct 31, 2024
View reviewed changes
libs/shared/src/utils/createTimestamp.ts Outdated Show resolved Hide resolved
...ews/MyParcelDeliveryOptions/Pickup/PickupLocationOpeningHours/PickupLocationOpeningHours.vue Outdated Show resolved Hide resolved
...ews/MyParcelDeliveryOptions/Pickup/PickupLocationOpeningHours/PickupLocationOpeningHours.vue Outdated Show resolved Hide resolved
...ews/MyParcelDeliveryOptions/Pickup/PickupLocationOpeningHours/PickupLocationOpeningHours.vue Outdated Show resolved Hide resolved
...ews/MyParcelDeliveryOptions/Pickup/PickupLocationOpeningHours/PickupLocationOpeningHours.vue Outdated Show resolved Hide resolved
...ews/MyParcelDeliveryOptions/Pickup/PickupLocationOpeningHours/PickupLocationOpeningHours.vue Outdated Show resolved Hide resolved
@myparcelnl myparcelnl deleted a comment from CleriseSwart Nov 21, 2024
EdieLemoine
EdieLemoine suggested changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@EdieLemoine EdieLemoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a feature, it's a bug fix, so the commit type should be fix. Also, the "Resolves #..." thing is for GitHub issues, when referring to a Jira ticket just put INT-xxx in the body. This is also mentioned in the "GitHub pull request workflow" on the wiki.

apps/delivery-options/src/composables/usePickupLocation.ts Outdated Show resolved Hide resolved
.idea/jsLinters/eslint.xml Outdated Show resolved Hide resolved
apps/delivery-options/src/composables/useLanguage.ts Outdated Show resolved Hide resolved
...ews/MyParcelDeliveryOptions/Pickup/PickupLocationOpeningHours/PickupLocationOpeningHours.vue Show resolved Hide resolved
...ews/MyParcelDeliveryOptions/Pickup/PickupLocationOpeningHours/PickupLocationOpeningHours.vue Show resolved Hide resolved
...ews/MyParcelDeliveryOptions/Pickup/PickupLocationOpeningHours/PickupLocationOpeningHours.vue Show resolved Hide resolved
...ews/MyParcelDeliveryOptions/Pickup/PickupLocationOpeningHours/PickupLocationOpeningHours.vue Show resolved Hide resolved
libs/shared/src/utils/createTimestamp.ts Outdated Show resolved Hide resolved
@MPClerise MPClerise changed the title feat: align pickup times with API data fix: align pickup times with API data Nov 25, 2024
@MPClerise MPClerise enabled auto-merge December 3, 2024 14:42
@joerivanveen joerivanveen disabled auto-merge December 3, 2024 15:07
@joerivanveen joerivanveen merged commit 70ec73b into main Dec 3, 2024
13 checks passed
@joerivanveen joerivanveen deleted the feature/INT-663 branch December 3, 2024 15:08
myparcel-bot bot added a commit that referenced this pull request Dec 3, 2024
@myparcel-bot
chore(release): 6.4.2 [skip ci]
65a50ea 
## [@myparcel/delivery-options-v6.4.2](v6.4.1...v6.4.2) (2024-12-03)

### 🐛 Bug Fixes

* align pickup times with API data ([#256](#256)) ([70ec73b](70ec73b))
@myparcel-bot
Copy link
Contributor

myparcel-bot bot commented Dec 3, 2024

🎉 This issue has been resolved in version @myparcel/delivery-options-v6.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@myparcel-bot myparcel-bot bot added the released label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdieLemoine EdieLemoine EdieLemoine requested changes

@FreekVR FreekVR FreekVR requested changes

@FlorianSDV FlorianSDV FlorianSDV approved these changes

@joerivanveen joerivanveen joerivanveen approved these changes

@RichardPerdaan RichardPerdaan RichardPerdaan approved these changes

Assignees
No one assigned
Labels
changes requested (Auto) released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MPClerise @FreekVR @EdieLemoine @RichardPerdaan @joerivanveen @FlorianSDV