Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support dhlforyou pickup locations correctly #254

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

GravendeelJochem
Copy link
Contributor

INT-671

Copy link

netlify bot commented Oct 14, 2024

Deploy Preview for myparcel-delivery-options ready!

Name Link
🔨 Latest commit f90281d
🔍 Latest deploy log https://app.netlify.com/sites/myparcel-delivery-options/deploys/671bb3fc52fcc700080752ce
😎 Deploy Preview https://deploy-preview-254--myparcel-delivery-options.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 14, 2024

Bundle Report

Changes will increase total bundle size by 117 bytes (0.04%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@myparcel/delivery-options-MyParcelDeliveryOptionsLib-esm 153.0kB 65 bytes (0.04%) ⬆️
@myparcel/delivery-options-MyParcelDeliveryOptionsLib-esm-MyParcelDeliveryOptionsLib-umd 118.14kB 52 bytes (0.04%) ⬆️

@GravendeelJochem GravendeelJochem marked this pull request as ready for review October 14, 2024 08:17
@GravendeelJochem GravendeelJochem requested a review from a team as a code owner October 14, 2024 08:17
@GravendeelJochem GravendeelJochem changed the title feat: allow small package pickup for DHLForYou in BE feat: support DHLForYou pickup locations correctly Oct 15, 2024
@myparcel-bot myparcel-bot bot added the approved (Auto) label Oct 15, 2024
@EdieLemoine EdieLemoine changed the title feat: support DHLForYou pickup locations correctly feat: support dhlforyou pickup locations correctly Oct 17, 2024
@myparcel-bot myparcel-bot bot force-pushed the feat/allow-smallpackage-pickup-dhlforyou-be branch from 690e456 to c1359e5 Compare October 25, 2024 14:16
@myparcel-bot myparcel-bot bot force-pushed the feat/allow-smallpackage-pickup-dhlforyou-be branch from c1359e5 to f90281d Compare October 25, 2024 15:06
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.21%. Comparing base (c323d75) to head (f90281d).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #254   +/-   ##
=======================================
  Coverage   75.20%   75.21%           
=======================================
  Files         342      342           
  Lines        7369     7370    +1     
  Branches      628      628           
=======================================
+ Hits         5542     5543    +1     
  Misses       1208     1208           
  Partials      619      619           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GravendeelJochem GravendeelJochem added this pull request to the merge queue Nov 7, 2024
Merged via the queue into main with commit bdd42a1 Nov 7, 2024
13 checks passed
@GravendeelJochem GravendeelJochem deleted the feat/allow-smallpackage-pickup-dhlforyou-be branch November 7, 2024 11:26
myparcel-bot bot added a commit that referenced this pull request Nov 7, 2024
## [@myparcel/delivery-options-v6.4.0](v6.3.1...v6.4.0) (2024-11-07)

### ✨ New Features

* support dhlforyou pickup locations correctly ([#254](#254)) ([bdd42a1](bdd42a1))
@myparcel-bot
Copy link
Contributor

myparcel-bot bot commented Nov 7, 2024

🎉 This issue has been resolved in version @myparcel/delivery-options-v6.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@myparcel-bot myparcel-bot bot added the released label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants