Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pickup): fix map not reloading on address change #223

Conversation

FreekVR
Copy link
Contributor

@FreekVR FreekVR commented May 1, 2024

Works around an issue where the pickup locations would never refresh, due to memoization not having any arguments to build a cache key from when loading available pickup locations.

INT-464

@FreekVR FreekVR requested a review from a team as a code owner May 1, 2024 13:44
Copy link

netlify bot commented May 1, 2024

Deploy Preview for myparcel-delivery-options ready!

Name Link
🔨 Latest commit 66ef51d
🔍 Latest deploy log https://app.netlify.com/sites/myparcel-delivery-options/deploys/664dc6da81bf87000884af19
😎 Deploy Preview https://deploy-preview-223--myparcel-delivery-options.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 1, 2024

Bundle Report

Changes will increase total bundle size by 381 bytes ⬆️

Bundle name Size Change
@myparcel/delivery-options-MyParcelDeliveryOptionsLib 114.3kB 381 bytes ⬆️

Copy link
Contributor

@EdieLemoine EdieLemoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

je titel is niet goed

@myparcel-bot myparcel-bot bot added the changes requested (Auto) label May 1, 2024
@FreekVR FreekVR changed the title Feat/fix map not reloading with pickup points on address change fix: fix map not reloading with pickup points on address change May 1, 2024
@FreekVR FreekVR force-pushed the feat/fix-map-not-reloading-with-pickup-points-on-address-change branch from 4238fc4 to cc9b7fe Compare May 1, 2024 13:56
@FreekVR FreekVR requested a review from EdieLemoine May 1, 2024 13:57
Copy link
Contributor

@EdieLemoine EdieLemoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bedoelde de cb, maar dit werkt ook 😛

@myparcel-bot myparcel-bot bot removed the changes requested (Auto) label May 1, 2024
@EdieLemoine EdieLemoine changed the title fix: fix map not reloading with pickup points on address change fix(pickup): fix map not reloading on address change May 1, 2024
@FreekVR FreekVR marked this pull request as draft May 1, 2024 14:50
@FreekVR
Copy link
Contributor Author

FreekVR commented May 1, 2024

Gaat toch iets mis in de sandbox waar ik met handmatige invoer niet tegenaan liep, lijkt een race condition achtig probleem, ima check :(

@FreekVR FreekVR force-pushed the feat/fix-map-not-reloading-with-pickup-points-on-address-change branch from cc9b7fe to 0e71cbf Compare May 7, 2024 16:41
@FreekVR FreekVR requested a review from EdieLemoine May 7, 2024 16:43
@FreekVR FreekVR force-pushed the feat/fix-map-not-reloading-with-pickup-points-on-address-change branch from 0e71cbf to 17bc71f Compare May 7, 2024 16:43
@FreekVR FreekVR marked this pull request as ready for review May 7, 2024 16:55
@FreekVR FreekVR requested a review from a team May 7, 2024 16:55
@myparcel-bot myparcel-bot bot added the approved (Auto) label May 14, 2024
@CherMyParcel CherMyParcel requested a review from joerivanveen May 17, 2024 08:30
@myparcel-bot myparcel-bot bot force-pushed the feat/fix-map-not-reloading-with-pickup-points-on-address-change branch from 17bc71f to 903ad01 Compare May 22, 2024 09:25
@myparcel-bot myparcel-bot bot force-pushed the feat/fix-map-not-reloading-with-pickup-points-on-address-change branch from 903ad01 to 66ef51d Compare May 22, 2024 10:20
@EdieLemoine EdieLemoine added this pull request to the merge queue May 23, 2024
Merged via the queue into main with commit 0a65fb4 May 23, 2024
12 checks passed
@EdieLemoine EdieLemoine deleted the feat/fix-map-not-reloading-with-pickup-points-on-address-change branch May 23, 2024 13:18
myparcel-bot bot added a commit that referenced this pull request May 23, 2024
## [@myparcel/delivery-options-v6.1.3](v6.1.2...v6.1.3) (2024-05-23)

### 🐛 Bug Fixes

* **pickup:** fix map not reloading on address change ([#223](#223)) ([0a65fb4](0a65fb4))
@myparcel-bot
Copy link
Contributor

myparcel-bot bot commented May 23, 2024

🎉 This PR is included in version @myparcel/delivery-options-v6.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants