-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pickup): fix map not reloading on address change #223
fix(pickup): fix map not reloading on address change #223
Conversation
✅ Deploy Preview for myparcel-delivery-options ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle ReportChanges will increase total bundle size by 381 bytes ⬆️
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
je titel is niet goed
apps/delivery-options/src/composables/useResolvedPickupLocations.ts
Outdated
Show resolved
Hide resolved
4238fc4
to
cc9b7fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bedoelde de cb, maar dit werkt ook 😛
Gaat toch iets mis in de sandbox waar ik met handmatige invoer niet tegenaan liep, lijkt een race condition achtig probleem, ima check :( |
cc9b7fe
to
0e71cbf
Compare
0e71cbf
to
17bc71f
Compare
17bc71f
to
903ad01
Compare
903ad01
to
66ef51d
Compare
## [@myparcel/delivery-options-v6.1.3](v6.1.2...v6.1.3) (2024-05-23) ### 🐛 Bug Fixes * **pickup:** fix map not reloading on address change ([#223](#223)) ([0a65fb4](0a65fb4))
🎉 This PR is included in version @myparcel/delivery-options-v6.1.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Works around an issue where the pickup locations would never refresh, due to memoization not having any arguments to build a cache key from when loading available pickup locations.
INT-464