Skip to content

Commit

Permalink
feat: allow small package pickup for DHLForYou in BE
Browse files Browse the repository at this point in the history
  • Loading branch information
GravendeelJochem committed Oct 14, 2024
1 parent e3a569d commit 86c492b
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 2 deletions.
4 changes: 3 additions & 1 deletion apps/delivery-options/src/utils/getResolvedCarrier.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,9 @@ describe('getResolvedCarrier', () => {
it('exposes package types DHL For You', () => {
const carrier = getResolvedCarrier(CarrierName.DhlForYou, PlatformName.MyParcel);

expect(carrier.packageTypes.value).toEqual(new Set([PackageTypeName.Package, PackageTypeName.Mailbox]));
expect(carrier.packageTypes.value).toEqual(
new Set([PackageTypeName.Package, PackageTypeName.Mailbox, PackageTypeName.PackageSmall]),
);
});

it('exposes package types PostNL', () => {
Expand Down
3 changes: 2 additions & 1 deletion libs/shared/src/config/getMyParcelConfig.ts
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,11 @@ export const getMyParcelConfig = (): PlatformConfiguration => ({
{
name: CarrierName.DhlForYou,
subscription: SubscriptionType.Optional,
packageTypes: [PackageTypeName.Package, PackageTypeName.Mailbox],
packageTypes: [PackageTypeName.Package, PackageTypeName.Mailbox, PackageTypeName.PackageSmall],
deliveryTypes: [DeliveryTypeName.Standard, DeliveryTypeName.Pickup, CustomDeliveryType.SameDay],
deliveryCountries: [NETHERLANDS, BELGIUM],
pickupCountries: [NETHERLANDS],
smallPackagePickupCountries: [NETHERLANDS, BELGIUM],
shipmentOptions: [ShipmentOptionName.OnlyRecipient, ShipmentOptionName.Signature],
features: [CarrierSetting.DeliveryDaysWindow, CarrierSetting.DropOffDays, CarrierSetting.DropOffDelay],
addressFields: [AddressField.City, AddressField.PostalCode],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,7 @@ exports[`getPlatformConfig > gets config for platform myparcel 1`] = `
"packageTypes": [
"package",
"mailbox",
"package_small",
],
"pickupCountries": [
"NL",
Expand All @@ -225,6 +226,10 @@ exports[`getPlatformConfig > gets config for platform myparcel 1`] = `
"only_recipient",
"signature",
],
"smallPackagePickupCountries": [
"NL",
"BE",
],
"subscription": -1,
},
{
Expand Down

0 comments on commit 86c492b

Please sign in to comment.