Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Crowdin updates #769

Merged
merged 17 commits into from
Nov 3, 2024
Merged

New Crowdin updates #769

merged 17 commits into from
Nov 3, 2024

Conversation

jibon57
Copy link
Member

@jibon57 jibon57 commented Nov 3, 2024

Summary by CodeRabbit

  • New Features

    • Added comprehensive translations for multiple languages, enhancing user notifications and error messages.
    • Introduced new entries for network errors, media server disconnections, and user actions.
  • Improvements

    • Updated existing translations for clarity and accuracy, including messages related to room disconnections and participant removal.
    • Enhanced error handling messages for better user guidance.
  • Localization

    • Expanded localization support with new translation files for Indonesian and updates across various languages, including Arabic, Bengali, German, Spanish, Persian, French, Italian, Japanese, Dutch, Portuguese, Russian, Turkish, Ukrainian, Chinese (Simplified and Traditional).

Copy link
Contributor

coderabbitai bot commented Nov 3, 2024

Caution

Review failed

The pull request is closed.

📝 Walkthrough
📝 Walkthrough

Walkthrough

The changes encompass updates to translation files for multiple languages, enhancing clarity and accuracy in user notifications and system messages. Key modifications involve rephrasing existing messages and adding new entries related to NATS server errors, media server disconnections, and user actions. The updates ensure that users receive clearer and more contextually appropriate information across various languages, improving the overall user experience.

Changes

File Path Change Summary
src/assets/locales/ar-SA/translation.json Updated translations for clarity, added new error messages related to NATS and media server issues, and modified existing keys to enhance user notifications.
src/assets/locales/bn-BD/translation.json Similar updates as in Arabic, with new entries for NATS errors and improved clarity in existing translations.
src/assets/locales/de-DE/translation.json Translations updated for clarity, with new entries for error notifications and system messages, including NATS server issues.
src/assets/locales/es-ES/translation.json Enhanced clarity in existing messages and added new entries for error handling and notifications related to server connections and user actions.
src/assets/locales/fa-IR/translation.json Updated translations for clarity, added new error messages, and improved existing keys to enhance user notifications.
src/assets/locales/fr-FR/translation.json Similar updates as in other languages, focusing on improving clarity and adding new entries for error handling and notifications.
src/assets/locales/id-ID/translation.json New file added with comprehensive translations for Indonesian, covering various user interface elements and notifications.
src/assets/locales/it-IT/translation.json Updated translations for clarity, added new entries for error handling, and modified existing keys for better user notifications.
src/assets/locales/ja-JP/translation.json Similar updates as in other languages, enhancing clarity and adding new error messages.
src/assets/locales/nl-NL/translation.json Updated existing translations for clarity and added new entries for error handling and notifications.
src/assets/locales/pt-PT/translation.json Enhanced clarity in existing messages, added new entries for error notifications, and improved user guidance in translations.
src/assets/locales/ru-RU/translation.json Updated translations for clarity, added new entries for error handling, and improved existing keys to enhance user communication.
src/assets/locales/tr-TR/translation.json Similar updates as in other languages, focusing on clarity and adding new entries for error handling and notifications.
src/assets/locales/uk-UA/translation.json Updated translations for clarity, added new entries for error messages, and improved existing notifications for better user experience.
src/assets/locales/zh-CN/translation.json Updated existing messages for clarity, added new entries for error handling, and improved user notifications.
src/assets/locales/zh-TW/translation.json Similar updates as in other Chinese translations, enhancing clarity and adding new entries for various error messages and notifications.

Poem

🐰 In the land of translations, we hop and play,
With clearer messages brightening the day.
From NATS to media, our words take flight,
Helping users connect, oh what a delight!
So here's to the changes, both big and small,
A joyful update for one and for all! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Nov 3, 2024

Deploy Preview for plugnmeet ready!

Name Link
🔨 Latest commit 1646ae3
🔍 Latest deploy log https://app.netlify.com/sites/plugnmeet/deploys/6727e1cd2add3a0008339206
😎 Deploy Preview https://deploy-preview-769--plugnmeet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Nov 3, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
JS files 1.13 MB (-0.01% 🔽) 23.2 s (-0.01% 🔽) 36.7 s (+43.5% 🔺) 59.9 s
CSS files 26.33 KB (0%) 527 ms (0%) 0 ms (+100% 🔺) 527 ms
Locales files 97.01 KB (0%) 2 s (0%) 0 ms (+100% 🔺) 2 s
Image files 1.65 MB (0%) 33.8 s (0%) 0 ms (+100% 🔺) 33.8 s
Font files 266.46 KB (0%) 5.4 s (0%) 0 ms (+100% 🔺) 5.4 s
Webassembly files 1.35 MB (0%) 27.7 s (0%) 0 ms (+100% 🔺) 27.7 s
All assets 4.52 MB (-0.01% 🔽) 92.6 s (-0.01% 🔽) 38.2 s (+14.68% 🔺) 130.8 s

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 59

🧹 Outside diff range and nitpick comments (20)
src/assets/locales/zh-CN/translation.json (1)

Multiple English strings found in Chinese translation file requiring localization

The verification confirms there are multiple untranslated English strings in the Chinese (zh-CN) locale file, including:

  • Room disconnection messages
  • WebSocket related messages
  • End-to-end encryption messages
  • Media server messages
  • Speech-to-text related features

These untranslated strings appear to be newer additions to the application, suggesting a systematic issue where new features are being added without proper localization.

🔗 Analysis chain

Line range hint 1-453: Verify translation consistency across the application.

While reviewing the changes, I noticed that new messages have been added in English instead of Chinese. This creates an inconsistent user experience.

Let's verify if this is a pattern across other language files:


Let me verify the actual content of these translations to see if this is a consistent pattern across all language files:


Let me check a few more English strings to confirm if this is a broader pattern:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check if other language files have the same keys in English
echo "Checking translation consistency across language files..."
rg -l "room-disconnected-duplicate-entry.*different user has already joined" "src/assets/locales/"

Length of output: 934


Script:

#!/bin/bash
# Check the actual translations for this key in different language files
for lang in zh-CN zh-TW ja-JP ko-KR; do
  echo "=== Checking $lang translation ==="
  rg -A 1 "room-disconnected-duplicate-entry" "src/assets/locales/$lang/translation.json"
done

Length of output: 1413


Script:

#!/bin/bash
# Check for other potentially untranslated strings in zh-CN
echo "=== Checking zh-CN translations for recent English strings ==="
rg -A 1 "websocket-disconnected|e2ee-unsupported-browser|media-server-disconnected|speech-to-text" "src/assets/locales/zh-CN/translation.json"

Length of output: 1344

src/assets/locales/ar-SA/translation.json (1)

Line range hint 1-453: Consider implementing a translation management system.

The consistent pattern of English strings in the Arabic locale file suggests a need for a more robust translation management workflow. Consider:

  1. Implementing a translation management system (TMS) to track missing translations
  2. Adding a development-time check to identify untranslated strings
  3. Using a placeholder system to mark strings pending translation

Would you like me to suggest some popular translation management tools that integrate well with your stack?

src/assets/locales/fa-IR/translation.json (1)

144-144: Fix inconsistent capitalization in English message.

The message "receiving session data..." should start with a capital letter to maintain consistency with other status messages in the file.

-    "receiving-data": "receiving session data...",
+    "receiving-data": "Receiving session data...",
src/assets/locales/bn-BD/translation.json (6)

36-39: Maintain English technical terms in translations.

The translation for "duplicate entry" message should preserve the technical term "userId" in English rather than translating it to Bengali, as it's a technical identifier.

-    "room-disconnected-duplicate-entry": "A different user has already joined with the same userId.",
+    "room-disconnected-duplicate-entry": "ভিন্ন ব্যবহারকারী ইতিমধ্যে একই userId দিয়ে যুক্ত হয়েছেন।",

42-42: Ensure consistent translation style for network-related messages.

The network error messages are in English while surrounding context uses Bengali. Maintain consistency by translating these messages.

-    "room-disconnected-network-error": "Room disconnected because of network error.",
+    "room-disconnected-network-error": "নেটওয়ার্ক সমস্যার কারণে রুম সংযোগ বিচ্ছিন্ন হয়েছে।",
-    "your-connection-quality-lost": "Your connection to the server has been lost",
+    "your-connection-quality-lost": "সার্ভারের সাথে আপনার সংযোগ হারিয়ে গেছে",

Also applies to: 44-44


53-60: Translate NATS server error messages to Bengali.

The NATS server error messages are in English. These should be translated to Bengali for consistency.

-    "nats-error-title": "Nats server connection error",
+    "nats-error-title": "Nats সার্ভার সংযোগ ত্রুটি",
-    "nats-error-no-response": "No backend server found to handle the request. Error: {{error}}",
+    "nats-error-no-response": "অনুরোধ পরিচালনা করার জন্য কোন ব্যাকএন্ড সার্ভার পাওয়া যায়নি। ত্রুটিঃ {{error}}",

61-66: Translate user status and whiteboard messages to Bengali.

These new messages should be translated to Bengali while preserving the technical terms.

-    "user-logged-out": "You logged out",
+    "user-logged-out": "আপনি লগআউট করেছেন",
-    "media-server-disconnected": "Media server disconnected.",
+    "media-server-disconnected": "মিডিয়া সার্ভার সংযোগ বিচ্ছিন্ন হয়েছে।",

423-423: Maintain placeholder consistency in translation messages.

The translation-related messages contain placeholders and technical terms. Ensure they're properly preserved while translating.

-    "translation-langs-label": "Translation languages (max: {{num}})",
+    "translation-langs-label": "অনুবাদের ভাষাসমূহ (সর্বোচ্চঃ {{num}})",
-    "renew-need-already-using-service": "Renew token can be requested only from existing user",
+    "renew-need-already-using-service": "শুধুমাত্র বিদ্যমান ব্যবহারকারী টোকেন নবায়নের অনুরোধ করতে পারবেন",

Also applies to: 442-443


195-196: Translate user interaction messages to Bengali.

These messages about user interactions should be translated to Bengali while preserving the placeholder structure.

-    "asked-you-to": "{{name}} asked you to {{task}}",
+    "asked-you-to": "{{name}} আপনাকে {{task}} করতে অনুরোধ করেছেন",
-    "you-have-asked": "You've asked {{name}} to {{task}}",
+    "you-have-asked": "আপনি {{name}} কে {{task}} করতে অনুরোধ করেছেন",
src/assets/locales/fr-FR/translation.json (1)

36-36: Improve consistency in room disconnection messages.

The room disconnection messages have been simplified by removing technical codes, which improves readability. However, these messages should maintain consistent punctuation.

-    "room-disconnected-duplicate-entry": "A different user has already joined with the same userId.",
-    "room-disconnected-participant-removed": "You have been removed from this conference",
-    "room-disconnected-room-ended": "The room has been closed",
+    "room-disconnected-duplicate-entry": "A different user has already joined with the same userId",
+    "room-disconnected-participant-removed": "You have been removed from this conference",
+    "room-disconnected-room-ended": "The room has been closed"

Also applies to: 38-39

src/assets/locales/ru-RU/translation.json (1)

Line range hint 1-443: General feedback on translation consistency.

  1. Several new features have English-only messages which need Russian translations:
    • Room disconnection messages
    • NATS server errors
    • Speech-to-text services
  2. Some sections mix Russian and English translations
  3. The translation quality varies across different sections

Recommendation: Consider using a professional translation service or native Russian speaker to review and complete the translations.

src/assets/locales/de-DE/translation.json (1)

42-44: New network error messages in English

These new network-related error messages are in English, continuing the pattern of using English for system messages. This is consistent with the changes above but different from most user-facing messages in the file which are in German.

Consider documenting this language choice in the localization guidelines to maintain consistency across future additions.

src/assets/locales/it-IT/translation.json (1)

Several English strings need translation in the Italian locale file

The following strings appear to be in English and need to be translated to Italian:

  • room-disconnected-duplicate-entry: "A different user has already joined with the same userId."
  • room-disconnected-room-ended: "The room has been closed"
  • room-disconnected-participant-removed: "You have been removed from this conference"
  • your-connection-quality-not-good: "Your connection quality isn't good enough"
  • your-connection-quality-lost: "Your connection to the server has been lost"
  • need-to-disable-display-external-link: "Display External Link is turned on. Please stop it before launching External Media Player."
  • need-to-disable-external-media-player: "External Media Player is turned on. Please stop it before launching Display External Link."
  • room-will-end-in: "This room will be ended in {{minutes}} minutes"
  • e2ee-unsupported-browser-msg: "This session has enabled end-to-end encryption which your current browser doesn't support."
  • require-ssl-title: "Domain must be SSL enabled"
  • require-ssl-des: "It is required to use an SSL-enabled domain other than localhost."
  • Multiple strings under the "speech-services" section
🔗 Analysis chain

Line range hint 1-453: Verify for additional untranslated strings

Let's check for other potential English strings that might need translation.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Find potential English strings in the Italian translation file
# Look for common English words that might indicate untranslated text
rg -i '\b(the|you|your|has|have|been|are|is|was|were|will|can|could|should|would|may|might|must|shall|this|that|these|those|there|their|they|it|its|we|our|us|my|your|his|her|its|their)\b' src/assets/locales/it-IT/translation.json

Length of output: 3322

src/assets/locales/es-ES/translation.json (1)

Line range hint 1-452: Consider completing translations before merging

While the PR updates translations, there are numerous new entries that remain in English. Consider:

  1. Completing all translations before merging
  2. Adding these strings to Crowdin for proper localization
  3. Maintaining a consistent review process to ensure all strings are translated

This will ensure a better experience for Spanish-speaking users.

src/assets/locales/id-ID/translation.json (6)

2-2: Maintain consistent capitalization for UI elements.

"Ok" should be "OK" as it's an acronym commonly written in uppercase.

-  "ok": "Ok",
+  "ok": "OK",

16-18: Maintain consistent sentence case and punctuation in notifications.

Messages should start with capital letters and end with appropriate punctuation for complete sentences.

-    "recording-already-running": "recording already running",
-    "recording-not-running": "recording not running",
-    "no-recorder-available": "no recorder available",
+    "recording-already-running": "Recording is already running.",
+    "recording-not-running": "Recording is not running.",
+    "no-recorder-available": "No recorder available.",

69-72: Maintain consistent grammar structure in status messages.

Add "is" consistently and end complete sentences with periods.

-    "session-recording": "This session is being recording",
-    "session-not-recording": "This session is no longer recording",
-    "rtmp-started": "This session is broadcasting using RTMP",
-    "rtmp-stopped": "This session is no longer broadcasting by RTMP"
+    "session-recording": "This session is being recorded.",
+    "session-not-recording": "This session is no longer being recorded.",
+    "rtmp-started": "This session is broadcasting using RTMP.",
+    "rtmp-stopped": "This session is no longer broadcasting via RTMP."

426-428: Improve grammar in validation messages.

Error messages should be grammatically correct and clear.

-    "speech-user-required": "At least one speech user require",
-    "speech-lang-required": "At least one speech language require",
-    "translation-lang-required": "At least one translation language or 2 speech languages required",
+    "speech-user-required": "At least one speech user is required.",
+    "speech-lang-required": "At least one speech language is required.",
+    "translation-lang-required": "At least one translation language or 2 speech languages are required.",

154-154: Standardize placeholder naming convention.

Use descriptive names consistently for placeholders across messages.

-    "participants": "Participants ({{total}})",
-    "confirm": "Are you sure to remove {{name}}?",
-    "has-raised-hand": "{{user}} has raised hand",
+    "participants": "Participants ({{participantCount}})",
+    "confirm": "Are you sure to remove {{userName}}?",
+    "has-raised-hand": "{{userName}} has raised hand",

Also applies to: 193-193, 270-270


394-394: Improve security guidance for external links.

The note should emphasize security requirements and use a more generic example.

-    "note": "Note: Make sure the URL has permission to open inside an iframe. Example: https://www.gameflare.com/embed/mini-survival",
+    "note": "Note: The URL must allow embedding via X-Frame-Options or Content-Security-Policy headers. Example: https://example.com/embed",
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 9f56ce5 and c2aac10.

📒 Files selected for processing (16)
  • src/assets/locales/ar-SA/translation.json (5 hunks)
  • src/assets/locales/bn-BD/translation.json (5 hunks)
  • src/assets/locales/de-DE/translation.json (5 hunks)
  • src/assets/locales/es-ES/translation.json (5 hunks)
  • src/assets/locales/fa-IR/translation.json (5 hunks)
  • src/assets/locales/fr-FR/translation.json (5 hunks)
  • src/assets/locales/id-ID/translation.json (1 hunks)
  • src/assets/locales/it-IT/translation.json (5 hunks)
  • src/assets/locales/ja-JP/translation.json (5 hunks)
  • src/assets/locales/nl-NL/translation.json (5 hunks)
  • src/assets/locales/pt-PT/translation.json (5 hunks)
  • src/assets/locales/ru-RU/translation.json (8 hunks)
  • src/assets/locales/tr-TR/translation.json (5 hunks)
  • src/assets/locales/uk-UA/translation.json (5 hunks)
  • src/assets/locales/zh-CN/translation.json (5 hunks)
  • src/assets/locales/zh-TW/translation.json (5 hunks)
🔇 Additional comments (18)
src/assets/locales/zh-TW/translation.json (2)

36-36: LGTM: Room disconnection messages are clear and consistent.

The translations effectively communicate different disconnection scenarios to users, maintaining consistency with other language files.

Also applies to: 38-39, 42-42


195-196: LGTM: User interaction messages are well structured.

The translations effectively communicate user interactions and requests between participants.

src/assets/locales/ja-JP/translation.json (4)

36-36: LGTM: Room disconnection messages are clear and informative.

The translations effectively communicate different disconnection scenarios to users, maintaining consistency while providing specific reasons for each case.

Also applies to: 38-39, 42-42, 44-44


53-66: LGTM: Comprehensive error handling messages added.

New translations effectively cover various system-level errors (NATS server, media server, authentication) with clear and user-friendly messages.


195-196: LGTM: Participant interaction messages are well-structured.

The translations effectively use placeholders and maintain a consistent, polite tone for user interactions.


423-423: LGTM: Speech service messages are clear and specific.

The translations effectively communicate service limitations and error conditions while maintaining consistency with the overall message style.

Also applies to: 442-443

src/assets/locales/nl-NL/translation.json (2)

Line range hint 1-443: Verify JSON structure and formatting

The JSON structure appears valid, but there are some formatting inconsistencies in the new entries compared to existing ones.

Let's verify the JSON structure and formatting:

#!/bin/bash
# Verify JSON validity and consistent formatting
jq '.' src/assets/locales/nl-NL/translation.json > /dev/null 2>&1
if [ $? -eq 0 ]; then
    echo "JSON is valid"
else
    echo "JSON has syntax errors"
fi

# Check for inconsistent quote usage
rg -U '["''](?:[^"'']|\\.)*["'']' src/assets/locales/nl-NL/translation.json

36-36: ⚠️ Potential issue

Room disconnection messages need Dutch translation

These messages are currently in English but should be translated to Dutch to maintain consistency with the rest of the localization file:

  • "A different user has already joined with the same userId."
  • "You have been removed from this conference"
  • "The room has been closed"

Let's verify if other language files have these messages properly translated:

Also applies to: 38-39

src/assets/locales/uk-UA/translation.json (1)

Line range hint 1-452: Verify JSON structure

The overall JSON structure is valid and well-formatted. All entries have proper key-value pairs and nested objects are correctly structured.

src/assets/locales/fr-FR/translation.json (1)

423-423: LGTM: Translation languages label is properly formatted.

The translation languages label correctly uses the variable interpolation for the maximum number of languages.

src/assets/locales/ru-RU/translation.json (3)

78-78: LGTM: Room screen share audio volume translation.

The translation "Уровень громкости демонстрации экрана" is accurate and consistent with the context.


52-66: ⚠️ Potential issue

New error messages require translation.

Multiple new error messages have been added in English and need Russian translations:

  • E2EE browser support message
  • NATS server connection errors
  • Decode errors
  • Authentication errors
#!/bin/bash
# Check if these new error messages are translated in other language files
rg -U "Nats server connection error" "src/assets/locales/**/translation.json"

423-423: ⚠️ Potential issue

Speech service settings require translation.

New speech-to-text service related messages are in English:

  • Translation languages max count message
  • Renew subscription messages
#!/bin/bash
# Check if these speech service messages are translated in other language files
rg -U "Renew subscription key not found" "src/assets/locales/**/translation.json"

Also applies to: 442-443

src/assets/locales/de-DE/translation.json (2)

52-66: Review needed: New system messages block

This large block of new system messages includes critical security and connection-related notifications. While keeping them in English is consistent with other system messages, some are user-facing and might benefit from localization.

#!/bin/bash
# Check if these messages are consistently in English across all language files
rg -U "nats-error-title|decode-error-title|media-server-disconnected" src/assets/locales/*/translation.json

Consider categorizing messages into:

  1. Technical system messages (keep in English)
  2. User-facing messages (translate to German)
    For example, "Media server disconnected" could be translated as it's a user-facing message.

36-39: Inconsistency: Messages switched from German to English

These messages were previously in German but have been changed to English. This appears to be an intentional change to standardize error messages, but it creates inconsistency with other German translations in the file.

Consider maintaining a separate namespace for standardized system messages if the intention is to keep certain technical messages in English across all locales.

src/assets/locales/pt-PT/translation.json (1)

Line range hint 1-443: Review needed: Systematic localization inconsistency.

There appears to be a systematic issue where new strings are being added in English instead of Portuguese throughout the file. This affects multiple sections including notifications, app messages, and speech services. Consider:

  1. Reviewing the Crowdin translation workflow to ensure new strings are properly queued for translation
  2. Adding a validation step to prevent untranslated strings from being merged
  3. Maintaining a list of pending translations that need to be addressed
#!/bin/bash
# Check for potential English strings in Portuguese translations
echo "Checking for potential untranslated strings..."
rg -U "^\\s+\"[^\"]+\":\\s+\"[A-Za-z\\s]+[^\"]+\"" src/assets/locales/pt-PT/translation.json | \
  grep -v -E "RTMP|NATS|WHIP|Ok|ID|URL" | \
  grep -i "[A-Za-z]" || echo "No obvious English strings found"
src/assets/locales/it-IT/translation.json (1)

423-423: LGTM! Parameter addition is correct

The addition of the max parameter to the translation languages label is properly implemented.

src/assets/locales/id-ID/translation.json (1)

1-453: Overall structure and completeness looks good.

The translation file is well-structured and covers all necessary UI elements. The JSON syntax is valid, and the hierarchical organization is clear and logical.

src/assets/locales/zh-CN/translation.json Show resolved Hide resolved
@@ -403,7 +420,7 @@
"speech-users-label": "Speech users",
"subtitle-font-size": "Subtitle font size",
"enable-translation": "Enable translation",
"translation-langs-label": "Translation languages",
"translation-langs-label": "Translation languages (max: {{num}})",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Speech service messages need translation.

New speech service related messages are in English:

Suggested translations:

-    "translation-langs-label": "Translation languages (max: {{num}})",
+    "translation-langs-label": "翻译语言(最多:{{num}})",
-    "renew-need-already-using-service": "Renew token can be requested only from existing user",
+    "renew-need-already-using-service": "只有现有用户才能请求更新令牌",
-    "renew-subscription-key-not-found": "Renew subscription key not found",
+    "renew-subscription-key-not-found": "未找到更新订阅密钥"

Also applies to: 442-443

Comment on lines +52 to +53
"e2ee-unsupported-browser-msg": "This session has enabled end-to-end encryption which your current browser doesn't support.",
"nats-error-title": "Nats server connection error",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

E2EE browser support messages need translation.

End-to-end encryption related messages are in English:

Suggested translations:

-    "e2ee-unsupported-browser-msg": "This session has enabled end-to-end encryption which your current browser doesn't support.",
+    "e2ee-unsupported-browser-msg": "此会话已启用端到端加密,但您当前的浏览器不支持此功能。"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"e2ee-unsupported-browser-msg": "This session has enabled end-to-end encryption which your current browser doesn't support.",
"nats-error-title": "Nats server connection error",
"e2ee-unsupported-browser-msg": "此会话已启用端到端加密,但您当前的浏览器不支持此功能。",
"nats-error-title": "Nats server connection error",

Comment on lines +42 to +44
"room-disconnected-network-error": "Room disconnected because of network error.",
"your-connection-quality-not-good": "Your connection quality isn't good enough",
"your-connection-quality-lost": "Your connection to the server has been lost",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Network-related messages need translation.

New network-related messages are in English instead of Chinese:

Suggested translations:

-    "room-disconnected-network-error": "Room disconnected because of network error.",
+    "room-disconnected-network-error": "由于网络错误,会议室已断开连接",
-    "your-connection-quality-not-good": "Your connection quality isn't good enough",
+    "your-connection-quality-not-good": "您的连接质量不够好",
-    "your-connection-quality-lost": "Your connection to the server has been lost",
+    "your-connection-quality-lost": "您与服务器的连接已断开"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"room-disconnected-network-error": "Room disconnected because of network error.",
"your-connection-quality-not-good": "Your connection quality isn't good enough",
"your-connection-quality-lost": "Your connection to the server has been lost",
"room-disconnected-network-error": "由于网络错误,会议室已断开连接",
"your-connection-quality-not-good": "您的连接质量不够好",
"your-connection-quality-lost": "您与服务器的连接已断开"

Comment on lines +195 to +196
"asked-you-to": "{{name}} asked you to {{task}}",
"you-have-asked": "You've asked {{name}} to {{task}}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Participant interaction messages need consistent translation.

Some participant interaction messages are partially translated:

Suggested translations:

-    "asked-you-to": "{{name}} asked you to {{task}}",
+    "asked-you-to": "{{name}} 请求您 {{task}}",
-    "you-have-asked": "You've asked {{name}} to {{task}}",
+    "you-have-asked": "您已请求 {{name}} {{task}}"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"asked-you-to": "{{name}} asked you to {{task}}",
"you-have-asked": "You've asked {{name}} to {{task}}",
"asked-you-to": "{{name}} 请求您 {{task}}",
"you-have-asked": "您已请求 {{name}} {{task}}"

Comment on lines +195 to +196
"asked-you-to": "{{name}} asked you to {{task}}",
"you-have-asked": "You've asked {{name}} to {{task}}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

User interaction messages need Italian translation

These user interaction messages should be translated to Italian:

  • "{{name}} asked you to {{task}}"
  • "You've asked {{name}} to {{task}}"

Comment on lines +442 to +443
"renew-need-already-using-service": "Renew token can be requested only from existing user",
"renew-subscription-key-not-found": "Renew subscription key not found",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Error messages need Italian translation

These subscription-related error messages should be translated to Italian:

  • "Renew token can be requested only from existing user"
  • "Renew subscription key not found"

@@ -33,21 +33,37 @@
"room-disconnected-title": "Sala desconectada",
"room-disconnected-unknown": "La sala ha sido desconectada. Motivo: {{code}}",
"room-disconnected-client-initiated": "El cliente ha sido iniciado. Código: {{code}}",
"room-disconnected-duplicate-entry": "Otro usuario con el mismo userId se ha unido. Código: {{code}}",
"room-disconnected-duplicate-entry": "A different user has already joined with the same userId.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Missing Spanish translations for notification messages

Several notification messages are still in English and need to be translated to Spanish:

  • "A different user has already joined with the same userId"
  • "You have been removed from this conference"
  • "The room has been closed"
  • "Room disconnected because of network error"
  • "Your connection to the server has been lost"

Also applies to: 38-39, 42-42, 44-44

Comment on lines 53 to 66
"nats-error-title": "Nats server connection error",
"nats-error-no-response": "No backend server found to handle the request. Error: {{error}}",
"nats-error-timeout": "No response found from backend server. Error: {{error}}",
"nats-error-request-failed": "Sending request was not successful",
"decode-error-title": "Decoding error",
"decode-error-body": "We could not understand data sent from server",
"nats-error-auth-title": "Authentication error",
"nats-error-auth-body": "We was not able to verify your auth information. May be you are using an expired token?",
"user-logged-out": "You logged out",
"media-server-disconnected-reconnecting": "Media server disconnected, reconnecting...",
"media-server-disconnected": "Media server disconnected.",
"preloaded-whiteboard-file-processing": "Preloaded whiteboard file in progress",
"preloaded-whiteboard-file-processing-error": "Preloaded whiteboard file processing ended with error",
"max-num-participates-exceeded": "The maximum number of participates permitted for the session has been exceeded."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Missing Spanish translations for error messages

Multiple new error messages have been added but are still in English. These need to be translated to Spanish to maintain consistency in the user experience:

  • NATS server connection errors
  • Media server disconnection messages
  • Whiteboard processing messages
  • Authentication error messages

@@ -403,7 +420,7 @@
"speech-users-label": "Usuarios de voz",
"subtitle-font-size": "Subtitle font size",
"enable-translation": "Habilitar traducción",
"translation-langs-label": "Idiomas de traducción",
"translation-langs-label": "Translation languages (max: {{num}})",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Missing Spanish translations for speech service messages

The following speech service related messages need Spanish translations:

  • "Translation languages (max: {{num}})"
  • "Renew token can be requested only from existing user"
  • "Renew subscription key not found"

Also applies to: 442-443

@jibon57 jibon57 merged commit 2423ea1 into main Nov 3, 2024
7 of 8 checks passed
@jibon57 jibon57 deleted the l10n_main branch November 3, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant