Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add direct bytes support to FixedString type #26

Merged
merged 6 commits into from
Apr 24, 2018
Merged

add direct bytes support to FixedString type #26

merged 6 commits into from
Apr 24, 2018

Conversation

lidalei
Copy link
Contributor

@lidalei lidalei commented Feb 13, 2018

No description provided.

@coveralls
Copy link

coveralls commented Feb 13, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 95.403% when pulling 261a034 on lidalei:master into a3a2651 on mymarilyn:master.

@lidalei
Copy link
Contributor Author

lidalei commented Feb 13, 2018

When writing to FixedString type column, str and bytes can be passed. When reading FixedString type column always return bytes.

@xzkostyan
Copy link
Member

Thanks for your PR.

I'll review it later.

@k4otix k4otix mentioned this pull request Mar 30, 2018
Closed
@xzkostyan xzkostyan merged commit 31ab111 into mymarilyn:master Apr 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lidalei @coveralls @xzkostyan