This repository has been archived by the owner on Mar 23, 2021. It is now read-only.
main: fix gopkg.in path handling #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix a bug whereby the full import path was being used after the module path for locations within the cache. For example, previously we had a cache path like: /github.com/gobin-testrepos/simple-main/@v/v1.0.0/github.com/gobin-testrepos/simple-main/simple-main whereas this should actually have been: github.com/gobin-testrepos/simple-main/@v/v1.0.0/simple-main Fixes #65.
myitcv
force-pushed
the
fix_gopkg_handling
branch
2 times, most recently
from
d36e45f
to
96e86c0
Compare
myitcv
force-pushed
the
fix_gopkg_handling
branch
from
96e86c0
to
fd5726d
Compare
mvdan
approved these changes
Mar 27, 2019
| // we've already uniquely identified the module. If there are | ||
| // case flips within a module then... well, we'll see. | ||
| pkgRem := strings.TrimPrefix(mp.ImportPath, mp.Module.Path+"/") | ||
| mainrel = filepath.Join(md, filepath.FromSlash(pkgRem)) |
There was a problem hiding this comment.
shouldn't this be path, not filepath? since it's a module import path, and not a path of a directory on disk.
There was a problem hiding this comment.
filepath is correct here I think. md is the file path of the encoded module path. Hence it only makes sense to join another filepath.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix a bug whereby the full import path was being used after the
module path for locations within the cache.
Fixes #65.