Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't upsert empty tables into mongodb collections (fixes #2) #4

Merged
merged 2 commits into from
Dec 8, 2021

Conversation

myisaak
Copy link
Owner

@myisaak myisaak commented Dec 8, 2021

This PR provides a small bug fix (fixing #2) that produced the following error and an accompaning integration test:

Failed to insert object with error MongoInvalidArgumentError: Invalid BulkOperation, Batch cannot be empty

@todo
Copy link

todo bot commented Dec 8, 2021

Add document validation for Mongodb 3.6 and later

https://github.com/MyIsaak/sqlitemongo/blob/0307fd374bd4f20f3a57870b95899dc70d3f530a/sqlitemongo.js#L35-L40


This comment was generated by todo based on a TODO comment in 0307fd3 in #4. cc @myisaak.

@todo
Copy link

todo bot commented Dec 8, 2021

Add --overwrite option (fixes duplicate key errors)

https://github.com/MyIsaak/sqlitemongo/blob/0307fd374bd4f20f3a57870b95899dc70d3f530a/sqlitemongo.js#L39-L42


This comment was generated by todo based on a TODO comment in 0307fd3 in #4. cc @myisaak.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant