Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(release.config.js): use full commit hash in commit link #89

Merged
merged 4 commits into from
Oct 31, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ssf/defaults.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ ssf_node_anchors:
# An alternative method could be to use:
# `git describe --abbrev=0 --tags`
# yamllint disable rule:line-length
title: 'feat(semantic-release): implement for this formula'
body: '* Checked using https://github.com/myii/ssf-formula/pull/88'
title: 'fix(release.config.js): use full commit hash in commit link [skip ci]'
body: '* Automated using https://github.com/myii/ssf-formula/pull/89'
# yamllint enable rule:line-length
github:
owner: 'saltstack-formulas'
Expand Down
10 changes: 5 additions & 5 deletions ssf/files/default/.travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,8 @@ jobs:
{{- format_rubocop_linter() }}
{%- endif %}
# Install and run `commitlint`
- npm install @commitlint/config-conventional -D
- npm install @commitlint/travis-cli -D
- npm i -D @commitlint/config-conventional
@commitlint/travis-cli
- commitlint-travis
{%- if not travis.use_single_job_for_linters %}
# Run the `rubocop` linter in a separate job that is allowed to fail
Expand Down Expand Up @@ -188,9 +188,9 @@ jobs:
- maintainer contributor

# Install all dependencies required for `semantic-release`
- npm install @semantic-release/changelog@3 -D
- npm install @semantic-release/exec@3 -D
- npm install @semantic-release/git@7 -D
- npm i -D @semantic-release/changelog@3
@semantic-release/exec@3
@semantic-release/git@7
deploy:
provider: script
skip_cleanup: true
Expand Down
2 changes: 1 addition & 1 deletion ssf/files/default/release.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ module.exports = {
}

if (typeof commit.hash === `string`) {
commit.hash = commit.hash.substring(0, 7)
commit.shortHash = commit.hash.substring(0, 7)
}

if (typeof commit.subject === `string`) {
Expand Down
10 changes: 5 additions & 5 deletions ssf/files/tofs_ssf-formula/.travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,8 @@ jobs:
{{- format_rubocop_linter() }}
{%- endif %}
# Install and run `commitlint`
- npm install @commitlint/config-conventional -D
- npm install @commitlint/travis-cli -D
- npm i -D @commitlint/config-conventional
@commitlint/travis-cli
- commitlint-travis
{%- if not travis.use_single_job_for_linters %}
# Run the `rubocop` linter in a separate job that is allowed to fail
Expand Down Expand Up @@ -193,9 +193,9 @@ jobs:
- maintainer contributor

# Install all dependencies required for `semantic-release`
- npm install @semantic-release/changelog@3 -D
- npm install @semantic-release/exec@3 -D
- npm install @semantic-release/git@7 -D
- npm i -D @semantic-release/changelog@3
@semantic-release/exec@3
@semantic-release/git@7
deploy:
provider: 'script'
skip_cleanup: true
Expand Down
37 changes: 0 additions & 37 deletions ssf/files/tofs_ssf-formula/pre-commit_semantic-release.sh

This file was deleted.

106 changes: 0 additions & 106 deletions ssf/files/tofs_ssf-formula/release.config.js

This file was deleted.