This repository was archived by the owner on Nov 22, 2023. It is now read-only.
fix: upgrade to get Channel ID from ValidatePull #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Update: it works! It will clash with go-fil-markets until it's upgraded over there unfortunately. |
tchardin
force-pushed
the
tc/datatransfer-race-fix
branch
from
b11268f to
91d7964
Compare
|
@gallexis got the same thing here lol idk what's going on |
tchardin
force-pushed
the
tc/datatransfer-race-fix
branch
from
1678df9 to
1ce5e67
Compare
|
Did a hard reset before I merged main and then a force push lol |
|
See conversation at filecoin-project/go-data-transfer#212 for context. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to work nicely locally hopefully it works well on CI too