Merge typehandlers-jsr310 into the core. #974

harawata · 2017-04-11T18:25:49Z

typehandlers-jsr310 are for standard Java types and they belong to the core in the first place.
We didn't know how to include them in the core without breaking Java 6 compatibility, but we do now.
So I propose to merge them into the core.
It might be a little bit confusing at first, but I cannot think of any serious issue caused by this change.

Any thoughts?

Cc-ing: @emacarron @hazendaz @kazuki43zoo @trohovsky @raupachz

fix gh-879

kazuki43zoo

Hi @harawata, There is no objection with your proposal(It's great proposal). But I do not understand a mechanism to resolve for code that depends on different JDK versions on compile time yet... Could you explain it ? (The mechanism for test code is understanding already!)

And I've added some trivial comments.

kazuki43zoo · 2017-04-11T19:47:34Z

src/main/java/org/apache/ibatis/type/InstantTypeHandler.java

+import org.apache.ibatis.lang.UsesJava8;
+
+/**
+ * @author Tomas Rohovsky


I think @since 3.4.5 is need. (The same applies to other classes)

kazuki43zoo · 2017-04-11T19:49:12Z

src/main/java/org/apache/ibatis/type/InstantTypeHandler.java

@@ -0,0 +1,62 @@
+/**
+ *    Copyright 2016 the original author or authors.


I think changing a license header is need. (The same applies to other classes)

kazuki43zoo · 2017-04-11T19:50:21Z

src/main/java/org/apache/ibatis/type/JapaneseDateTypeHandler.java

+/**
+ * Type Handler for {@link JapaneseDate}.
+ *
+ * @since 1.0.2


I think changing version is need. (The same applies to other classes)

kazuki43zoo · 2017-04-11T19:51:55Z

src/main/java/org/apache/ibatis/type/Java8TypeHandlersRegistrar.java

+
+import org.apache.ibatis.lang.UsesJava8;
+
+@UsesJava8


I think adding javadoc(@since and @author etc..) is need.

kazuki43zoo · 2017-04-11T19:52:25Z

src/main/java/org/apache/ibatis/type/Java8TypeHandlersRegistrar.java

+public abstract class Java8TypeHandlersRegistrar {
+
+  public static void registerDateAndTimeHandlers(TypeHandlerRegistry registry) {
+    // since 1.0.0


I think this comment is not need.

kazuki43zoo · 2017-04-11T19:55:18Z

src/test/java/org/apache/ibatis/type/usesjava8/Jsr310TypeHandlerRegistryTest.java

@@ -40,29 +61,24 @@ public void setup() {

  @Test
  public void testFor_v1_0_0() throws ClassNotFoundException {


I think changing method name and merge to one method is need.

kazuki43zoo · 2017-04-11T19:56:24Z

src/test/java/org/apache/ibatis/type/usesjava8/Jsr310TypeHandlerRegistryTest.java

 import org.junit.Before;
 import org.junit.Test;

-import static org.junit.Assert.*;
-import static org.hamcrest.core.IsInstanceOf.*;
-
 /**
 * Tests for auto-detect type handlers of mybatis-typehandlers-jsr310.


I think changing this comment is need.

raupachz · 2017-04-12T07:29:56Z

Why don't you check System.getProperty("java.version");?

harawata · 2017-04-12T12:14:07Z

Thank you guys for the comments! =)

@kazuki43zoo ,
I'll update the files later.

@raupachz ,
The logic based on version string potentially causes an issue like this and should be avoided, IMHO.
As a related topic, the version string schema change in Java 9 might break some existing apps/libraries that rely on the old schema, I imagine.

raupachz · 2017-04-12T12:26:39Z

@harawata Ah, I see. Was just a suggestion. Probably all a matter of personal preference. Like most things.

harawata · 2017-04-12T12:33:53Z

@raupachz ;D Any suggestion is welcome!

# Conflicts: # src/test/java/org/apache/ibatis/type/usesjava8/Jsr310TypeHandlerRegistryTest.java

hazendaz · 2017-05-24T00:52:52Z

+1

See gh-974

Merge typehandlers-jsr310 into the core.

See mybatisgh-974

Merge typehandlers-jsr310 into the core.

1b53559

harawata referenced this pull request Apr 11, 2017

Add tests for auto-detecting mybatis-typehandlers-jsr310

8fc78a7

fix gh-879

kazuki43zoo reviewed Apr 11, 2017

View reviewed changes

Updated license headers and javadoc comments.

da6dca2

kazuki43zoo mentioned this pull request Apr 13, 2017

Add mybatis-typehandlers-jsr310 mybatis/spring-boot-starter#157

Closed

Merge branch 'master' into merge-typehandlers-jsr310

2da2275

# Conflicts: # src/test/java/org/apache/ibatis/type/usesjava8/Jsr310TypeHandlerRegistryTest.java

harawata merged commit a0308b1 into mybatis:master May 24, 2017

kazuki43zoo added the enhancement Improve a feature or add a new feature label Jun 7, 2017

kazuki43zoo added this to the 3.4.5 milestone Jun 7, 2017

kazuki43zoo added a commit that referenced this pull request Jun 13, 2017

Add typehandlers for JSR-310 in reference doc

4f0eef2

See gh-974

kazuki43zoo mentioned this pull request Jul 10, 2017

Drop dependency for mybatis-typehandlers-jsr310 when upgrade to MyBatis 3.4.5+ terasolunaorg/terasoluna-gfw#715

Closed

1 task

kazuki43zoo assigned harawata Jul 29, 2017

kazuki43zoo mentioned this pull request Aug 15, 2017

Update README for merged into mybatis 3.4.5 mybatis/typehandlers-jsr310#44

Closed

kazuki43zoo mentioned this pull request Sep 29, 2017

Revert to mybatis 3.4.4 and add note that indicate not upgrading pom.xml mybatis/typehandlers-jsr310#48

Closed

kazuki43zoo mentioned this pull request Feb 13, 2018

mybatis 3.4.5 include same classes with mybatis-typehandlers-jsr310 terasoluna-batch/v5-fw#9

Closed

hanakeichen mentioned this pull request May 23, 2018

JSR-310 support: Date and Time API zouzg/mybatis-generator-gui#182

Merged

kazuki43zoo mentioned this pull request Aug 9, 2019

About the date field in the oracle database #1623

Closed

pulllock pushed a commit to pulllock/mybatis-3 that referenced this pull request Oct 19, 2023

Merge pull request mybatis#974 from harawata/merge-typehandlers-jsr310

727baa0

Merge typehandlers-jsr310 into the core.

pulllock pushed a commit to pulllock/mybatis-3 that referenced this pull request Oct 19, 2023

Add typehandlers for JSR-310 in reference doc

94b8da2

See mybatisgh-974

linghengqian mentioned this pull request Dec 7, 2023

Add Interval implementation of InlineExpressionParser SPI apache/shardingsphere#29309

Merged

6 tasks

venkata91 mentioned this pull request Jul 17, 2024

[CELEBORN-1190][FOLLOWUP] Fix WARNING of error prone apache/celeborn#2555

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge typehandlers-jsr310 into the core. #974

Merge typehandlers-jsr310 into the core. #974

harawata commented Apr 11, 2017

kazuki43zoo left a comment •

edited

Loading

kazuki43zoo Apr 11, 2017

kazuki43zoo Apr 11, 2017 •

edited

Loading

kazuki43zoo Apr 11, 2017

kazuki43zoo Apr 11, 2017

kazuki43zoo Apr 11, 2017

kazuki43zoo Apr 11, 2017

kazuki43zoo Apr 11, 2017

raupachz commented Apr 12, 2017

harawata commented Apr 12, 2017 •

edited

Loading

raupachz commented Apr 12, 2017

harawata commented Apr 12, 2017

hazendaz commented May 24, 2017

		@@ -0,0 +1,62 @@
		/**
		* Copyright 2016 the original author or authors.

		@@ -40,29 +61,24 @@ public void setup() {

		@Test
		public void testFor_v1_0_0() throws ClassNotFoundException {

Merge typehandlers-jsr310 into the core. #974

Merge typehandlers-jsr310 into the core. #974

Conversation

harawata commented Apr 11, 2017

kazuki43zoo left a comment • edited Loading

Choose a reason for hiding this comment

kazuki43zoo Apr 11, 2017

Choose a reason for hiding this comment

kazuki43zoo Apr 11, 2017 • edited Loading

Choose a reason for hiding this comment

kazuki43zoo Apr 11, 2017

Choose a reason for hiding this comment

kazuki43zoo Apr 11, 2017

Choose a reason for hiding this comment

kazuki43zoo Apr 11, 2017

Choose a reason for hiding this comment

kazuki43zoo Apr 11, 2017

Choose a reason for hiding this comment

kazuki43zoo Apr 11, 2017

Choose a reason for hiding this comment

raupachz commented Apr 12, 2017

harawata commented Apr 12, 2017 • edited Loading

raupachz commented Apr 12, 2017

harawata commented Apr 12, 2017

hazendaz commented May 24, 2017

kazuki43zoo left a comment •

edited

Loading

kazuki43zoo Apr 11, 2017 •

edited

Loading

harawata commented Apr 12, 2017 •

edited

Loading