avoid unexpected automapping

[dulong]

avoid unexpected automapping when a explicit mapped proerty has the same name as another column

[harawata]

Could you provide a test case?

[dulong]

@harawata Hi, I added a test case to the existed auto mapping test suite

[harawata]

Thank you, @dulong ! =D

[kazuki43zoo]

@harawata , Is this enhancement or bug ?

[harawata]

A bug, I would say.

[kazuki43zoo]

Do not need a warning log in this case ?

[kazuki43zoo]

I think it should not use && condition in this case.

Because...
If resultMap.getMappedProperties().contains(property) is true, execute following code.

configuration.getAutoMappingUnknownColumnBehavior()
        .doAction(mappedStatement, columnName, (property != null) ? property : propertyName, null);

In this case, i think it is already mapped property rather than not unknown column.

[harawata]

I might not fully understand the expected behavior of autoMappingUnknownColumnBehavior.
Feel free to commit the necessary changes :)

[kazuki43zoo]

I might not fully understand the expected behavior of autoMappingUnknownColumnBehavior.

See #585.

I will improve a contributing code.

[harawata]

OK..I have to admit that I am a little bit confused 😆
Please let me clarify.

When running the contributed test case (AutomappingTest.shouldGetAUserWhithPhoneNumber()), four columns (id, name, phone and phone_number) are returned from the query and only three of them are mapped.

• 'phone_number' is explicitly mapped
• 'id' and 'name' are auto-mapped

I thought that the unmapped column 'phone' is an unknown column, but it actually isn't, is that correct?

[kazuki43zoo]

Hi @harawata

In My opinion, the phone is valid column name as auto-mapping (if does not use explicit mapping...), it skip because it has been mapped by explicit mapping already. Hence i think phone is not unknown column.
I think we should consider to apply a mechanism that notify duplicate mapping for same property (like same as autoMappingUnknownColumnBehavior).

for example:

• NONE: skip auto-mapping
• WARNING: skip auto-mapping and output warning log that notify duplicate mapping for same property
• FAILING : throw exception that that notify duplicate mapping for same property

What do you think ?

[harawata]

Hence i think phone is not unknown column.

Okay, I have no strong opinion about this.

I think we should consider to apply a mechanism that notify duplicate mapping for same property (like same as autoMappingUnknownColumnBehavior).

The duplicate mapping situation like this would be rare.
And this unknown column detection can be inaccurate [1] anyway, so let's consider when someone desperately wants it ;)

[1] There will be false-positives with a nested result map.

[kazuki43zoo]

let's consider when someone desperately wants it ;)

Okay :)

[kazuki43zoo]

Hi @harawata and @dulong,
I've improved contributing code via a5895f7. If my change has problem, please post comment.

Thanks.

[dulong]

Hi @kazuki43zoo , thanks for the improvement, i appreciated that 👍