Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize ResultFlag #2947

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Optimize ResultFlag #2947

wants to merge 1 commit into from

Conversation

kang-hl
Copy link
Contributor

@kang-hl kang-hl commented Aug 30, 2023

No description provided.

@hazendaz hazendaz self-assigned this Aug 31, 2023
@hazendaz hazendaz requested a review from harawata August 31, 2023 21:18
@coveralls
Copy link

Coverage Status

coverage: 86.693% (-0.01%) from 86.703% when pulling 49335ad on kang-hl:optimize-ResultFlag into ead5a1d on mybatis:master.

@hazendaz
Copy link
Member

looks ok, not familiar with seeing |= but that may be ok. I'm not familiar enough with the underlying usage to know if this is correct though. @harawata What do you think here?

@harawata
Copy link
Member

I am OK with the basic idea (i.e. use byte instead of List), but I may want to make some minor changes before we merge it.

Also, even though this is an internal change (in my opinion), it might be safer to wait for 4.0 (or 3.6) because it could break some third party extensions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harawata harawata Awaiting requested review from harawata

Assignees

@hazendaz hazendaz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kang-hl @coveralls @hazendaz @harawata