-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translated to Traditional Chinese #2586
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Did you guys verify the result of |
@harawata Is there any translation guideline? I don't know how to do it right. Should I modify |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should add zh_TW
in pom.xml
for maven site plugin
I tried so many ways to generate |
I think this issue is caused by Apache Maven Site Plugin. I created a bug report here: https://issues.apache.org/jira/browse/MSITE-904 |
<td><code>parameterType</code></td> | ||
<td> | ||
將會傳入這條語句的參數的類別全限定名或別名。這個屬性是可選的,因為 | ||
MyBatis 可以透過型別處理器(TypeHandler)推斷出具體傳入語句的參數,預設值為未設定(unset)。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#2836 same error here
<td><code>parameterType</code></td> | ||
<td> | ||
將會傳入這條語句的參數的類別全限定名或別名。這個屬性是可選的,因為 | ||
MyBatis 可以透過型別處理器(TypeHandler)推斷出具體傳入語句的參數,預設值為未設定(unset)。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#2836 +1
It seems we could work on this issue now. |
@awxiaoxian2020 Are you able to support different |
I just notice that we have moved maven site 4. |
So I should send another PR, right? |
You can just resolve the conflict I think. |
@awxiaoxian2020 I'm struggling with the build process. I tried to build mybatis-3 project in the docker container: docker run -it --rm --name=mybatis maven:3-eclipse-temurin-11 bash I git clone https://github.com/mybatis/mybatis-3.git --depth=1
cd mybatis-3
ARG_LINE=-D"argLine=--illegal-access=permit"
./mvnw test -B -V --no-transfer-progress -D"license.skip=true" -D"jacoco.skip=true" $ARG_LINE
./mvnw help:active-profiles
./mvnw site site:stage -DskipTests -B -V --no-transfer-progress -Dlicense.skip=true Then I'll get the following errors:
Do you know how to fix it? |
@doggy8088 Javadocs are rather misleading. Ignore the [error] on left as its hiding real issue. Instead look at the right hand side. Bulk of those are warnings which is ok. There is an error on the right though that does need fixed. Also if you could fix your merge conflicts while at it. |
I just want to make sure I can build this project before I contribute translations. Why you haven't met this issue? |
Your branch is conflicted, its failing because its conflicted. Try fixing your conflicts and try again. |
@hazendaz I know it's conflicting. I'm not building my branch. I'm building |
Master builds fine against the following https://github.com/mybatis/mybatis-3/blob/master/.github/workflows/ci.yaml, what problem are you having exactly? jdk 11 is required at a minimum to build. The item mentioned above from you earlier I presume was this build. However, I see you changed no source so that is odd. Its a javadoc issue. Its clear what it is there but its not failing on our master. If you have some time, take a look at what you are seeing there and if really issue on our end, please send a PR to fix. It looks trivial but unclear to me at the moment why you would see that but we don't. |
It is during site so it could be related to this change, are you saying master is doing that from the site? |
No description provided.