Fix issue #2080 #2084
Closed
Fix issue #2080 #2084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harawata
reviewed
Oct 11, 2020
| + " <if test=\"sex != null\">\n" | ||
| + " STUDENT.SSEX = #{sex};\n" | ||
| + " </if>\n" | ||
| + " and STUDENT.SNO = SCORE.SNO and HOUSE.HOUSE_MEMBER = STUDENT.SNO\n" |
There was a problem hiding this comment.
This line is missing in ex and the indentation of </if> looks wrong.
|
There are some logic mistakes, I'm already in process. By the way, the issue#2080 is more complicated than I thought. |
wuwen5
reviewed
Jun 2, 2021
| @@ -306,20 +307,24 @@ public Float getFloatAttribute(String name, Float def) { | |||
| } | |||
| } | |||
|
|
|||
| public List<XNode> getChildren() { | |||
| public List<XNode> getChildren(Predicate<Node> predicate) { | |||
There was a problem hiding this comment.
this change has nothing to do with the issue#2080
Closed
harawata
added a commit
to harawata/mybatis-3
that referenced
this pull request
Nov 7, 2023
- Keeping indentation, but it won't be perfect in multi-line text nodes. - Add a new line after each open/close tag even for a short line like `<id>3</id>`. There aren't many short lines like that in MyBatis mappers. - Use 2 spaces for indentation instead of 4 to save earth. Should fix mybatis#2080 Should close mybatis#2084 mybatis#2552 mybatis#2998
harawata
added a commit
to harawata/mybatis-3
that referenced
this pull request
Nov 7, 2023
- Keeping indentation, but it won't be perfect in multi-line text nodes. - Add a new line after each open/close tag even for a short line like `<id>3</id>`. There aren't many short lines like that in MyBatis mappers. - Use 2 spaces for indentation instead of 4 to save earth. Should fix mybatis#2080 Should close mybatis#2084 mybatis#2552 mybatis#2998
|
Closed in favor of #3001 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue @harawata TBR