-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support LIMIT and OFFSET on SQL builder class #1521
Conversation
I've fixed gh-1518.
WDYT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Useful feature 👍
@jeffgbutler , |
I am OK with this. I tried to make clear in the dynamic-sql documentation that this isn’t a “magic” method meaning that it won’t translate to something else for databases that don’t support limit and offset. But most databases do support it now so the caution is mainly for Oracle users :) |
Thank you, @jeffgbutler ! I just checked and ANSI SQL chose
Anyway, I agree that LIMIT/OFFSET still is a popular syntax, so I also have no objection. |
@harawata @jeffgbutler @kezhenxu94 Thanks for your review! I will merge this PR after updating documentation(plant to includes the note that same as mybatis-synamic-sql). And I consider to support "FETCH FIRST" clause by another issue. Thank you again! |
Support LIMIT and OFFSET on SQL class
Fixes gh-1518