Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support anonymous enum object that implement method #1490

Merged
merged 5 commits into from
Mar 4, 2019
Merged

Support anonymous enum object that implement method #1490

merged 5 commits into from
Mar 4, 2019

Conversation

kazuki43zoo
Copy link
Member

Fixes gh-1489

zhzhsx and others added 3 commits March 4, 2019 21:05
@zhzhsx @kazuki43zoo
add a test to reproduce problem of enum type handler
51710ed 
MyBatis cannot find the type handler for an enum when 1. the enum value has
methods, 2. no parameterType is provided in corresponding insert mappers
@kazuki43zoo
Support anonymous enum object that implement method
73c3320 
Fixes mybatisgh-1489
@kazuki43zoo
Support anonymous enum object that implement interface method
2420632 
Related with mybatisgh-1489
@kazuki43zoo kazuki43zoo requested a review from harawata March 4, 2019 12:48
@kazuki43zoo
Polishing for mybatis#1489
f7ed824 
* Change to use isAssignableFrom method
* Add local variable to hold Enum class
@kazuki43zoo
Change to use getSuperclass() instread of getEnclosingClass() mybatis…
c6672b5 
…#1489
@kazuki43zoo
Copy link
Member Author

@harawata Thanks for your review!! I've fixed your comment now. Please review again.
Thanks.

harawata
harawata approved these changes Mar 4, 2019
View reviewed changes
Copy link
Member

@harawata harawata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for the quick fix!
(...and sorry about the verbose comments)

@kazuki43zoo kazuki43zoo merged commit ff7dc3b into mybatis:master Mar 4, 2019
@kazuki43zoo kazuki43zoo deleted the gh-1489-enum-with-method branch March 4, 2019 14:30
@kazuki43zoo kazuki43zoo self-assigned this Mar 4, 2019
@xrayw xrayw mentioned this pull request Sep 16, 2023
Closed
pulllock pushed a commit to pulllock/mybatis-3 that referenced this pull request Oct 19, 2023
@kazuki43zoo
Merge pull request mybatis#1490 from kazuki43zoo/mybatisgh-1489-enum-…
6006b92 
…with-method

Support anonymous enum object that implement method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harawata harawata harawata approved these changes

Assignees

@kazuki43zoo kazuki43zoo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kazuki43zoo @harawata @zhzhsx