Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add defaultResultSetType as global configuration #1056

Merged
merged 8 commits into from
Jul 7, 2019

Conversation

kazuki43zoo
Copy link
Member

I want to support the defaultResultSetType as global configuration.
By this change, we can change a result set type to SCROLL_SENSITIVE or SCROLL_INSENSITIVE from default(FORWARD_ONLY) by globally (and easily).

What do you think for this PR ?
Please review this.

Thanks.

@kazuki43zoo kazuki43zoo added the enhancement Improve a feature or add a new feature label Jul 17, 2017
@kazuki43zoo kazuki43zoo self-assigned this Jul 17, 2017
@harawata
Copy link
Member

After looking at #1334 #1344 , this seems to be a reasonable enhancement. 👍

@kazuki43zoo
Copy link
Member Author

@harawata Thanks for your reaction!
I've fixed conflict and update doc. Please confirm again when you have a time.

Copy link
Member

@harawata harawata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @kazuki43zoo !

@kazuki43zoo kazuki43zoo requested a review from harawata July 6, 2019 16:59
@kazuki43zoo kazuki43zoo added this to the 3.5.2 milestone Jul 6, 2019
@kazuki43zoo kazuki43zoo force-pushed the default-resultset-type branch from d93ae87 to 7765a86 Compare July 7, 2019 02:11
Copy link
Member

@harawata harawata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, @kazuki43zoo !
LGTM :)

@kazuki43zoo kazuki43zoo merged commit 6e9e4c2 into mybatis:master Jul 7, 2019
@kazuki43zoo kazuki43zoo deleted the default-resultset-type branch July 7, 2019 08:19
pulllock pushed a commit to pulllock/mybatis-3 that referenced this pull request Oct 19, 2023
Add defaultResultSetType as global configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve a feature or add a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants