Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supports log4j-core 2.6+(2.11) #1210

Closed
kazuki43zoo opened this issue Mar 18, 2018 · 1 comment · Fixed by #1215
Closed

Supports log4j-core 2.6+(2.11) #1210

kazuki43zoo opened this issue Mar 18, 2018 · 1 comment · Fixed by #1215
Assignees
@kazuki43zoo
Labels
enhancement Improve a feature or add a new feature
Milestone
3.5.0

Comments

@kazuki43zoo
Copy link
Member

kazuki43zoo commented Mar 18, 2018 •
edited
Loading

I've tried to upgrade to the log4j-core 2.10.0 (latest version). However, a compile error occurs on Log4j2AbstractLoggerImpl.
This behavior occurs on 2.6+.

Related Links
@kazuki43zoo kazuki43zoo added this to the 3.5.0 milestone Mar 18, 2018
@kazuki43zoo kazuki43zoo added the enhancement Improve a feature or add a new feature label Mar 18, 2018
@kazuki43zoo kazuki43zoo mentioned this issue Mar 18, 2018
Merged
@kazuki43zoo
Copy link
Member Author

Since log4j 2.6, the SimpleMessage(implementation class of Message) implements the CharSequence and it added the logger method for the CharSequence in Logger class. Therefore current implementation of Log4j2AbstractLoggerImpl cannot be identified the logger method by method arguments because it exists already the logger method for the Message interface in Logger class.

Probably, we can resolve this issue by casting explicitly to the Message.

kazuki43zoo added a commit to kazuki43zoo/mybatis-3 that referenced this issue Mar 19, 2018
@kazuki43zoo
Casting explicitly to the Message mybatis#1210
c54ced1
kazuki43zoo added a commit to kazuki43zoo/mybatis-3 that referenced this issue Mar 19, 2018
@kazuki43zoo
Upgrade to log4j-core 2.11.0 mybatis#1210
99967dd
@kazuki43zoo kazuki43zoo mentioned this issue Mar 19, 2018
Merged
kazuki43zoo added a commit that referenced this issue Mar 19, 2018
@kazuki43zoo
Merge pull request #1215 from kazuki43zoo/gh-1210-upgrade-to-log4j-2.…
8e80c18 
…11.0

Supports log4j 2.6+(2.11)
@kazuki43zoo kazuki43zoo changed the title Can not upgrade to log4j-core 2.6+ Supports log4j-core 2.6+(2.11) Mar 19, 2018
@kazuki43zoo kazuki43zoo self-assigned this Mar 19, 2018
pulllock pushed a commit to pulllock/mybatis-3 that referenced this issue Oct 19, 2023
@kazuki43zoo
Casting explicitly to the Message mybatis#1210
5a91c00
pulllock pushed a commit to pulllock/mybatis-3 that referenced this issue Oct 19, 2023
@kazuki43zoo
Upgrade to log4j-core 2.11.0 mybatis#1210
361f2a2
pulllock pushed a commit to pulllock/mybatis-3 that referenced this issue Oct 19, 2023
@kazuki43zoo
Merge pull request mybatis#1215 from kazuki43zoo/mybatisgh-1210-upgra…
c2b471b 
…de-to-log4j-2.11.0

Supports log4j 2.6+(2.11)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kazuki43zoo kazuki43zoo

Labels
enhancement Improve a feature or add a new feature
Projects
None yet
Milestone
3.5.0
Development

Successfully merging a pull request may close this issue.

Supports log4j 2.6+(2.11) kazuki43zoo/mybatis-3
1 participant
@kazuki43zoo