Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix wordlist selector #192

Merged
merged 1 commit into from
Mar 4, 2024
Merged

fix wordlist selector #192

merged 1 commit into from
Mar 4, 2024

Conversation

WebFreak001
Copy link
Contributor

was spamming API requests while wordlist selector was visible

gammelalf
gammelalf reviewed Mar 1, 2024
View reviewed changes
Copy link
Contributor

@gammelalf gammelalf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why introduce the possibility of undefined which requires several checks,
instead of an empty dependency which would only be 4 characters?

@WebFreak001
fix wordlist selector
3f6fa39 
was spamming API requests while wordlist selector was visible
@WebFreak001 WebFreak001 force-pushed the frontend-fix-wordlist-selectors branch from 413cbb2 to 3f6fa39 Compare March 4, 2024 17:27
@myOmikron myOmikron merged commit 5f80c52 into myOmikron:main Mar 4, 2024
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2024
@WebFreak001 WebFreak001 deleted the frontend-fix-wordlist-selectors branch March 18, 2024 22:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gammelalf gammelalf gammelalf left review comments

@myOmikron myOmikron myOmikron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WebFreak001 @gammelalf @myOmikron